Release v1.28.0

.circleci/config.yml

@@ -1,5 +1,8 @@
 version: 2.1
 
+orbs:
+  slack: circleci/slack@3.4.2
+
 commands:
   yarn-install:
     steps:
@@ -60,6 +63,11 @@ jobs:
       - store_test_results:
           path: ./reports/test-results
   android-device-checks:
+    parameters:
+      post-to-slack:
+        description: Post to Slack when tests fail. SLACK_WEBHOOK ENV variable must be set.
+        type: boolean
+        default: false
     docker:
     - image: circleci/android:api-29-node
     steps:
@@ -89,7 +97,20 @@ jobs:
             JEST_JUNIT_OUTPUT: "reports/test-results/android-test-results.xml"
       - store_test_results:
           path: ./reports/test-results
+      - when:
+          condition: << parameters.post-to-slack >>
+          steps:
+            - slack/status:
+                fail_only: true
+                include_job_number_field: false
+                include_project_field: false
+                failure_message: ':red_circle: Scheduled tests failed on Android device!'
   ios-device-checks:
+    parameters:
+      post-to-slack:
+        description: Post to Slack when tests fail. SLACK_WEBHOOK ENV variable must be set.
+        type: boolean
+        default: false
     macos:
       xcode: "11.2.1"
     steps:
@@ -156,6 +177,14 @@ jobs:
         key: ios-build-cache-{{ checksum "ios-checksums.txt" }}
         paths:
           - ios/build/gutenberg/Build/Products/Release-iphonesimulator/GutenbergDemo.app
+    - when:
+          condition: << parameters.post-to-slack >>
+          steps:
+            - slack/status:
+                fail_only: true
+                include_job_number_field: false
+                include_project_field: false
+                failure_message: ':red_circle: Scheduled tests failed on iOS device!'
 
 workflows:
   gutenberg-mobile:
@@ -175,3 +204,18 @@ workflows:
           name: Test iOS on Device
       - android-device-checks:
           name: Test Android on Device
+
+  ui-tests-full-scheduled:
+    jobs:
+      - ios-device-checks:
+          name: Test iOS on Device - Scheduled
+          post-to-slack: true
+      - android-device-checks:
+          name: Test Android on Device - Scheduled
+          post-to-slack: true
+    triggers:
+      - schedule:
+          cron: '1 1,13 * * *'
+          filters:
+            branches:
+              only: develop

CODE_OF_CONDUCT.md

@@ -0,0 +1,28 @@
+# Contributor Code of Conduct
+
+As contributors and maintainers of this project, and in the interest of fostering an open and welcoming community, we pledge to respect all people who contribute through reporting issues, posting feature requests, updating documentation, submitting pull requests or patches, and other activities.
+
+We are committed to making participation in this project a harassment-free experience for everyone, regardless of level of experience, gender, gender identity and expression, sexual orientation, disability, personal appearance, body size, race, ethnicity, age, religion, or nationality.
+
+Examples of unacceptable behavior by participants include:
+
+* The use of sexualized language or imagery
+* Personal attacks
+* Trolling or insulting/derogatory comments
+* Public or private harassment
+* Publishing other's private information, such as physical or electronic addresses, without explicit permission
+* Other unethical or unprofessional conduct
+
+Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, or to ban temporarily or permanently any contributor for other behaviors that they deem inappropriate, threatening, offensive, or harmful.
+
+By adopting this Code of Conduct, project maintainers commit themselves to fairly and consistently applying these principles to every aspect of managing this project. Project maintainers who do not follow or enforce the Code of Conduct may be permanently removed from the project team.
+
+This Code of Conduct applies both within project spaces and in public spaces when an individual is representing the project or its community.
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by emailing a project maintainer via https://make.wordpress.org/community/contact/, with a subject (the field labeled `Your Question`) that includes `Code of Conduct`. All complaints will be reviewed and investigated and will result in a response that is deemed necessary and appropriate to the circumstances. Maintainers are obligated to maintain confidentiality with regard to the reporter of an incident.
+
+
+This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.3.0, available at [http://contributor-covenant.org/version/1/3/0/][version]
+
+[homepage]: http://contributor-covenant.org
+[version]: http://contributor-covenant.org/version/1/3/0/

RELEASE-NOTES.txt

@@ -1,3 +1,12 @@
+1.28.0
+------
+* [***] New block: Pullquote
+* [**] Add support for changing background and text color in Buttons block
+* [*] Fix the icons and buttons in Gallery, Paragraph, List and MediaText block on RTL mode
+* [**] Remove Subscription Button from the Blog template since it didn't have an initial functionality and it is hard to configure for users.
+* [**] [iOS] Add support for the subscript `<sub>` and superscript `<sup>`HTML elements in text blocks
+* [**] Update page templates to use recently added blocks
+
 1.27.1
 ------
 * Remove Subscription Button from the Blog template since it didn't have an initial functionality and it is hard to configure for users.

RNTAztecView.podspec

@@ -18,6 +18,6 @@ Pod::Spec.new do |s|
   s.xcconfig         = {'OTHER_LDFLAGS' => '-lxml2',
                         'HEADER_SEARCH_PATHS' => '/usr/include/libxml2'}
   s.dependency         'React-Core'
-  s.dependency         'WordPress-Aztec-iOS', '~> 1.18.0'
+  s.dependency         'WordPress-Aztec-iOS', '~> 1.19.0'
 
 end

__device-tests__/gutenberg-editor-block-insertion.test.js

@@ -22,6 +22,7 @@ describe( 'Gutenberg Editor tests for Block insertion', () => {
 	let driver;
 	let editorPage;
 	let allPassed = true;
+	const paragraphBlockName = 'Paragraph';
 
 	// Use reporter for setting status for saucelabs Job
 	if ( ! isLocalEnvironment() ) {
@@ -45,21 +46,23 @@ describe( 'Gutenberg Editor tests for Block insertion', () => {
 	} );
 
 	it( 'should be able to insert block into post', async () => {
-		await editorPage.addNewParagraphBlock();
-		let paragraphBlockElement = await editorPage.getParagraphBlockAtPosition( 1 );
+		await editorPage.addNewBlock( paragraphBlockName );
+		let paragraphBlockElement = await editorPage.getBlockAtPosition( paragraphBlockName );
 		if ( isAndroid() ) {
 			await paragraphBlockElement.click();
 		}
-		await editorPage.sendTextToParagraphBlockAtPosition( 1, testData.longText );
+
+		await editorPage.sendTextToParagraphBlock( 1, testData.longText );
 		// Should have 3 paragraph blocks at this point
 
-		paragraphBlockElement = await editorPage.getParagraphBlockAtPosition( 2 );
+		paragraphBlockElement = await editorPage.getBlockAtPosition( paragraphBlockName, 2 );
 		await paragraphBlockElement.click();
 
-		await editorPage.addNewParagraphBlock();
-		paragraphBlockElement = await editorPage.getParagraphBlockAtPosition( 3 );
+		await editorPage.addNewBlock( paragraphBlockName );
+
+		paragraphBlockElement = await editorPage.getBlockAtPosition( paragraphBlockName, 3 );
 		await paragraphBlockElement.click();
-		await editorPage.sendTextToParagraphBlockAtPosition( 3, testData.mediumText );
+		await editorPage.sendTextToParagraphBlock( 3, testData.mediumText );
 
 		await editorPage.verifyHtmlContent( testData.blockInsertionHtml );
 
@@ -68,34 +71,40 @@ describe( 'Gutenberg Editor tests for Block insertion', () => {
 
 		// Workaround for now since deleting the first element causes a crash on CI for Android
 		if ( isAndroid() ) {
-			paragraphBlockElement = await editorPage.getParagraphBlockAtPosition( 3, { autoscroll: true } );
+			paragraphBlockElement = await editorPage.getBlockAtPosition( paragraphBlockName, 3, {
+				autoscroll: true,
+			} );
+
 			await paragraphBlockElement.click();
-			await editorPage.removeParagraphBlockAtPosition( 3 );
+			await editorPage.removeBlockAtPosition( paragraphBlockName, 3 );
 			for ( let i = 3; i > 0; i-- ) {
 				// wait for accessibility ids to update
 				await driver.sleep( 1000 );
-				paragraphBlockElement = await editorPage.getParagraphBlockAtPosition( i, { autoscroll: true } );
+				paragraphBlockElement = await editorPage.getBlockAtPosition( paragraphBlockName, i, {
+					autoscroll: true,
+				} );
 				await paragraphBlockElement.click();
-				await editorPage.removeParagraphBlockAtPosition( i );
+				await editorPage.removeBlockAtPosition( paragraphBlockName, i );
 			}
 		} else {
 			for ( let i = 4; i > 0; i-- ) {
 				// wait for accessibility ids to update
 				await driver.sleep( 1000 );
-				paragraphBlockElement = await editorPage.getParagraphBlockAtPosition( 1 );
+				paragraphBlockElement = await editorPage.getBlockAtPosition( paragraphBlockName );
 				await clickMiddleOfElement( driver, paragraphBlockElement );
-				await editorPage.removeParagraphBlockAtPosition( 1 );
+				await editorPage.removeBlockAtPosition( paragraphBlockName );
 			}
 		}
 	} );
 
 	it( 'should be able to insert block at the beginning of post from the title', async () => {
-		await editorPage.addNewParagraphBlock();
-		let paragraphBlockElement = await editorPage.getParagraphBlockAtPosition( 1 );
+		await editorPage.addNewBlock( paragraphBlockName );
+		let paragraphBlockElement = await editorPage.getBlockAtPosition( paragraphBlockName );
 		if ( isAndroid() ) {
 			await paragraphBlockElement.click();
 		}
-		await editorPage.sendTextToParagraphBlockAtPosition( 1, testData.longText );
+
+		await editorPage.sendTextToParagraphBlock( 1, testData.longText );
 		// Should have 3 paragraph blocks at this point
 
 		if ( isAndroid() ) {
@@ -107,10 +116,10 @@ describe( 'Gutenberg Editor tests for Block insertion', () => {
 		await titleElement.click();
 		await titleElement.click();
 
-		await editorPage.addNewParagraphBlock();
-		paragraphBlockElement = await editorPage.getParagraphBlockAtPosition( 1 );
+		await editorPage.addNewBlock( paragraphBlockName );
+		paragraphBlockElement = await editorPage.getBlockAtPosition( paragraphBlockName );
 		await clickMiddleOfElement( driver, paragraphBlockElement );
-		await editorPage.sendTextToParagraphBlockAtPosition( 1, testData.mediumText );
+		await editorPage.sendTextToParagraphBlock( 1, testData.mediumText );
 		await paragraphBlockElement.click();
 		await editorPage.verifyHtmlContent( testData.blockInsertionHtmlFromTitle );
 	} );

__device-tests__/gutenberg-editor-gallery.test.js

@@ -6,18 +6,15 @@
  * Internal dependencies
  */
 import EditorPage from './pages/editor-page';
-import {
-	setupDriver,
-	isLocalEnvironment,
-	stopDriver,
-} from './helpers/utils';
+import { setupDriver, isLocalEnvironment, stopDriver } from './helpers/utils';
 
 jasmine.DEFAULT_TIMEOUT_INTERVAL = 1000000;
 
 describe( 'Gutenberg Editor Gallery Block tests', () => {
 	let driver;
 	let editorPage;
 	let allPassed = true;
+	const galleryBlockName = 'Gallery';
 
 	// Use reporter for setting status for saucelabs Job
 	if ( ! isLocalEnvironment() ) {
@@ -40,11 +37,11 @@ describe( 'Gutenberg Editor Gallery Block tests', () => {
 	} );
 
 	it( 'should be able to add a gallery block', async () => {
-		await editorPage.addNewGalleryBlock();
-		const galleryBlock = await editorPage.getGalleryBlockAtPosition( 1 );
+		await editorPage.addNewBlock( galleryBlockName );
+		const galleryBlock = await editorPage.getBlockAtPosition( galleryBlockName );
 
 		expect( galleryBlock ).toBeTruthy();
-		await editorPage.removeGalleryBlockAtPosition( 1 );
+		await editorPage.removeBlockAtPosition( galleryBlockName );
 	} );
 
 	afterAll( async () => {

__device-tests__/gutenberg-editor-heading.test.js

@@ -6,12 +6,7 @@
  * Internal dependencies
  */
 import EditorPage from './pages/editor-page';
-import {
-	setupDriver,
-	isLocalEnvironment,
-	stopDriver,
-	isAndroid,
-} from './helpers/utils';
+import { setupDriver, isLocalEnvironment, stopDriver, isAndroid } from './helpers/utils';
 import testData from './helpers/test-data';
 
 jasmine.DEFAULT_TIMEOUT_INTERVAL = 1000000;
@@ -20,6 +15,8 @@ describe( 'Gutenberg Editor tests', () => {
 	let driver;
 	let editorPage;
 	let allPassed = true;
+	const paragraphBlockName = 'Paragraph';
+	const headingBlockName = 'Heading';
 
 	// Use reporter for setting status for saucelabs Job
 	if ( ! isLocalEnvironment() ) {
@@ -42,29 +39,28 @@ describe( 'Gutenberg Editor tests', () => {
 	} );
 
 	it( 'should be able to create a post with heading and paragraph blocks', async () => {
-		await editorPage.addNewHeadingBlock();
-		let headingBlockElement = await editorPage.getHeadingBlockAtPosition( 1 );
-
+		await editorPage.addNewBlock( headingBlockName );
+		let headingBlockElement = await editorPage.getBlockAtPosition( headingBlockName );
 		if ( isAndroid() ) {
 			await headingBlockElement.click();
 		}
 		await editorPage.sendTextToHeadingBlock( headingBlockElement, testData.heading, false );
 
-		await editorPage.addNewParagraphBlock();
-		let paragraphBlockElement = await editorPage.getParagraphBlockAtPosition( 2 );
-		await editorPage.sendTextToParagraphBlock( paragraphBlockElement, testData.mediumText );
+		await editorPage.addNewBlock( paragraphBlockName );
+		let paragraphBlockElement = await editorPage.getBlockAtPosition( paragraphBlockName, 2 );
+		await editorPage.typeTextToParagraphBlock( paragraphBlockElement, testData.mediumText );
 
-		await editorPage.addNewParagraphBlock();
-		paragraphBlockElement = await editorPage.getParagraphBlockAtPosition( 3 );
-		await editorPage.sendTextToParagraphBlock( paragraphBlockElement, testData.mediumText );
+		await editorPage.addNewBlock( paragraphBlockName );
+		paragraphBlockElement = await editorPage.getBlockAtPosition( paragraphBlockName, 3 );
+		await editorPage.typeTextToParagraphBlock( paragraphBlockElement, testData.mediumText );
 
-		await editorPage.addNewHeadingBlock();
-		headingBlockElement = await editorPage.getHeadingBlockAtPosition( 4 );
-		await editorPage.sendTextToHeadingBlock( headingBlockElement, testData.heading, false );
+		await editorPage.addNewBlock( headingBlockName );
+		headingBlockElement = await editorPage.getBlockAtPosition( headingBlockName, 4 );
+		await editorPage.typeTextToParagraphBlock( headingBlockElement, testData.heading );
 
-		await editorPage.addNewParagraphBlock();
-		paragraphBlockElement = await editorPage.getParagraphBlockAtPosition( 5 );
-		await editorPage.sendTextToParagraphBlock( paragraphBlockElement, testData.mediumText );
+		await editorPage.addNewBlock( paragraphBlockName );
+		paragraphBlockElement = await editorPage.getBlockAtPosition( paragraphBlockName, 5 );
+		await editorPage.typeTextToParagraphBlock( paragraphBlockElement, testData.mediumText );
 	} );
 
 	afterAll( async () => {