Fix incorrect block insertion point after blurring post title#3640
Merged
dcalhoun merged 2 commits intoJun 21, 2021
Conversation
7 tasks
fluiddot
reviewed
Jun 21, 2021
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
fluiddot
approved these changes
Jun 21, 2021
Contributor
fluiddot
left a comment
fluiddot
left a comment
There was a problem hiding this comment.
Approved via WordPress/gutenberg#32831 (review) 🎊 .
Selecting the title selection status within the same `useSelect` for reusable blocks caused the title selection status to become stale, due to the dependency array for the `useSelect` hook. The staleness caused the block insertion point to show up in the incorrect location after blurring the title text input.
dcalhoun
force-pushed
the
fix/incorrect-block-insertion-after-title-focus
branch
from
455dded to
12cac37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3636. Selecting the title selection status within the same
useSelectfor reusable blocks caused the title selection status to become stale, due to the dependency array for theuseSelecthook. The staleness caused the block insertion point to show up in the incorrect location after blurring the title text input.To test: See WordPress/gutenberg#32831.
PR submission checklist: