Skip to content

Merge release 1.55.2 to develop#3655

Merged
dcalhoun merged 11 commits into
developfrom
merge_release_1.55.2_to_develop
Jun 23, 2021
Merged

Merge release 1.55.2 to develop#3655
dcalhoun merged 11 commits into
developfrom
merge_release_1.55.2_to_develop

Conversation

@dcalhoun
Copy link
Copy Markdown
Member

@dcalhoun dcalhoun commented Jun 23, 2021

Merges latest 1.55.2 release into develop branch.

To test: Verify the gutenberg ref points to the merge commit of the release branch.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile Bot commented Jun 23, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@dcalhoun dcalhoun marked this pull request as ready for review June 23, 2021 16:10
@dcalhoun dcalhoun requested a review from fluiddot June 23, 2021 16:10
@dcalhoun dcalhoun enabled auto-merge June 23, 2021 16:10
Comment thread RELEASE-NOTES.txt
@fluiddot
Copy link
Copy Markdown
Contributor

I noticed that the Check Correctness CI job is failing due to differences in the package-lock.json file, maybe we need to run npm install and update the file, wdyt?

@dcalhoun
Copy link
Copy Markdown
Member Author

I noticed that the Check Correctness CI job is failing due to differences in the package-lock.json file, maybe we need to run npm install and update the file, wdyt?

I had done so once before after the initial Check Correctness failure, so I am puzzled as to why it is still failing. I'll try npm install again in hopes of getting passing results.

Copy link
Copy Markdown
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 !

@dcalhoun dcalhoun merged commit 9bf5319 into develop Jun 23, 2021
@dcalhoun dcalhoun deleted the merge_release_1.55.2_to_develop branch June 23, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants