Skip to content

Release 1.57.0#3714

Merged
AmandaRiu merged 282 commits into
trunkfrom
release/1.57.0
Jul 9, 2021
Merged

Release 1.57.0#3714
AmandaRiu merged 282 commits into
trunkfrom
release/1.57.0

Conversation

@ceyhun
Copy link
Copy Markdown
Contributor

@ceyhun ceyhun commented Jul 9, 2021 •
edited
Loading

Release for Gutenberg Mobile 1.57.0

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Test plan

  • Use the main WP apps to test the changes above.
  • Smoke test the main WP apps for general writing flow.
  • Test the Unsupported Block Editor on WP Apps (see steps).
  • Sanity test suites for WP Apps should be completed for each platform.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Approve and run optional Android and iOS UI tests
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release.
  • Bundle package of the release is updated.

ceyhun and others added 30 commits May 21, 2021 18:25
@ceyhun
Update podspecs by running generate-podspecs.sh script
affb5ff
@cameronvoell
Updating gutenberg ref
d9e8a95
@cameronvoell
Merge branch 'develop' into try/upgrade-0-64
191e88a
@cameronvoell
Update bundle
1ae1978
@ceyhun
Update gutenberg ref
eac4768
@ceyhun
Revert "Disabled npm cache on CI"
9ad755f 
This reverts commit 3958c64.
@jd-alexander
Updated gutenberg ref.
aedcb75
@ceyhun
Modify generate-podspecs.sh script to run FBReactNativeSpec codegen a…
d6422ff 
…head of time
@ceyhun
Update gutenberg ref
900921c
@ceyhun
Update package-lock.json
310ff4c
@ceyhun
Update package-lock.json
3ebb08a
@ceyhun
Add workaround for FBReactNativeSpec podspec in generate-poscpecs.sh …
49563f4 
…script
@ceyhun
Update commit hash of FBReactNativeSpec
0267a7e
@ceyhun
Fix typo
4d5c216
@ceyhun
Update commit hash of FBReactNativeSpec
75d3ff9
@ceyhun
Add missing external podspecs to generate-podspecs.sh script
590b352
@ceyhun
Re-generate third-party-podspecs, remove react-native-linear-gradient…
6646ca0 
… podspec
@ceyhun
Update commit hash of FBReactNativeSpec
504cae3
@ceyhun
Add exception for react-native-slider fork
c092aba
@ceyhun
Remove tag from react-native-slider podspec
dffe6f9
@ceyhun
Fix react-native-slider git source
5bbfc23
@SiobhyB
Bump Gutenberg
41eefea
@ceyhun
Merge branch 'develop' into try/upgrade-0-64
c2652ed
@ceyhun
Update gutenberg ref
3fea75d
@ceyhun
Update bundles
ab02d3a
Update gutenberg reference
50bf41a
Update release notes with fix for Gboard enter detection
10950c3
@ceyhun
Update gutenberg ref
6eef209
@ceyhun
Merge branch 'develop' into try/upgrade-0-64
e368d21
@ceyhun
Update jetpack ref
a4d4202
This was referenced Jul 9, 2021
Merged
Merged
Merged
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile Bot commented Jul 9, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@ceyhun ceyhun requested a review from AmandaRiu July 9, 2021 13:06
@ceyhun ceyhun marked this pull request as ready for review July 9, 2021 13:06
AmandaRiu
AmandaRiu approved these changes Jul 9, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@AmandaRiu AmandaRiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@AmandaRiu AmandaRiu merged commit c1b06df into trunk Jul 9, 2021
@AmandaRiu AmandaRiu deleted the release/1.57.0 branch July 9, 2021 20:55
@AmandaRiu
Copy link
Copy Markdown
Contributor

AmandaRiu commented Jul 12, 2021 •
edited
Loading

Writing Flow checklist (WPAndroid)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@AmandaRiu
Copy link
Copy Markdown
Contributor

AmandaRiu commented Jul 12, 2021 •
edited
Loading

Unsupported Block Tests (WPAndroid)

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@ceyhun
Copy link
Copy Markdown
Contributor Author

ceyhun commented Jul 12, 2021 •
edited
Loading

Writing Flow checklist (iOS)

Tested with WPiOS 17.8.0.0, iOS 14.6

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@ceyhun
Copy link
Copy Markdown
Contributor Author

ceyhun commented Jul 12, 2021 •
edited
Loading

Unsupported Block Tests (iOS)

Tested with WPiOS 17.8.0.0, iOS 14.6

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • 🔴 TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites -> I'm still able to see the option to edit the block and when I press it, it stays stuck in loading.
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@enejb
Copy link
Copy Markdown
Contributor

enejb commented Jul 12, 2021 •
edited
Loading

Tested with WPiOS 17.8.0.20210712, iOS 14.6 iPhone Pro

DarkMode - 2

  • Spacer block - Dark mode - TC004
  • Buttons block - Dark mode - TC005
  • Group - Dark mode - TC006
  • Columns - Dark mode - TC007

🔴 - The slider control colours are off. (Particularly the part that displays the number)
You can replicate this by looking using the slider in the spacer block but it is also found in other block settings such as button and column.

Group - 2

  • Group - Navigation up button works as expected - TC009
  • Group - Navigation down works according to parent-first approach - TC010
  • Group - Cross navigation between blocks works as expected - TC011
  • Group - Ungroup button works as expected - TC012
  • Group - Check if in DarkMode all components gets proper colors - TC013
  • Group - Check if nested Placeholder block can be replaced - TC014

Spacer - 2

  • Spacer block - Settings: Available height range is correct - TC004
  • Spacer block - Settings: Height range extends if Spacer comes from the web is higher than 500px - TC005
  • Spacer block - Spacer in horizontal layout works as expected - TC006

Buttons - 4

  • Buttons block - Render custom text color - TC017
  • Buttons block - Render custom background color - TC016
  • Buttons block - Render gradient background color - TC018
  • Buttons block - Check if selection / caret color matches font color - TC020
  • Buttons block - The newly created Buttons has set background color to the theme-default color in preview - TC021

Buttons - 5

  • Buttons block - Edit text styles - TC009
  • Buttons block - Render theme colors - TC019
    🔴 Buttons block - Settings: Change Button border radius - TC015
    Saving the button radius doesn't work as expected.

Buttons - 7

  • Buttons block - Link from the clipboard is automatically added into the empty URL field in link settings and button options - TC008
  • Buttons block - Toolbar link button is active when Button has link - TC022

Editor Theme - 2

  • Custom Gradients - Check that custom gradients load in the editor - TC004
  • Offline Support - TC005

Color Settings - 2

  • Pressing color swatch - TC004
  • Customize gradient color - TC005
  • Custom color picker - TC006

@chipsnyder
Copy link
Copy Markdown
Contributor

chipsnyder commented Jul 12, 2021 •
edited
Loading

WPAndroid Sanity Tests

Tested on a Pixel 3a API 30 running the build from 17.8-rc-1

Test Suite 3

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009

Gallery - 3

  • Gallery block - Add Gallery Caption - TC003
  • Gallery block - Add Gallery Image Caption - TC004
  • Gallery block - Try adding same images from WP Media library and moving the images around - TC010

Gallery - 4

  • Gallery block - Settings: Link to - TC012
  • Gallery block - Settings: Column number - TC013
  • Gallery block - Settings: Crop images - TC014

Columns - 2

  • Columns - Max limit of Column number - steps
  • Columns - Min limit of Column number - steps
  • Columns - Removing Column with remove button - steps
  • Columns - Removing the only one left Column with remove button - steps
  • Columns - Changing alignment on Columns - steps
  • Columns - Changing alignment on individual Columnn - steps
  • Columns - Alignment attribute is properly passed when adding Column - steps

Columns - 3

  • Columns - Check if Column placeholders is visible for the unselected state - steps
  • Columns - Appearance in vertical device position (vertical layout) - steps
  • Columns - Appearance in horizontal device position (horizontal layout) - steps
  • Columns - Mover direction - steps
  • Columns - Check if Column placeholder is render in nested structure - steps
  • Columns - Unselected Column placeholder is streched to content in nested structure- steps

Columns - 4

  • Columns - Check if in DarkMode all components gets proper colors - steps

MediaText - 3

  • Media Text block - Insert video from device (failing) - TC001-v
  • Media Text block - Close/Re-open post with an ongoing video upload - TC003-v

MediaText - 4

  • Media Text block - Media & Text alignment - TC006
  • Media Text block - Vertical alignment - TC007

Shortcode-1

  • Shortcode block - Add a youtube link - steps

Cover - 2

  • Cover - Add Video Background from WordPress Media library - TC005
  • Cover - Replace media - TC006
  • Cover - Gradient background is rendered properly - TC007
  • Cover - Gradient overlay is rendered properly - TC008

Social Icons - 2

  • The link sheet is opened automatically when adding new icon - TC004
  • Ghost placeholder is visible when no icon is active - TC005
  • Social icon forwarding to the link - TC006

Image - 2

  • Image block - Border style setting - TC007
  • Image block - Image size setting - TC008
  • Image block - Link to setting - TC009

Story block - 1

  • Story block - Verify is available in Block Picker - TC001
  • Story block - Verify is not available in Block Picker- TC002
  • Story block - Add media to empty Story block - TC003
  • Story block - Add media to non-empty Story block - TC004
  • Story block - Close/Re-open post with an ongoing Story upload - TC005

@AmandaRiu
Copy link
Copy Markdown
Contributor

AmandaRiu commented Jul 12, 2021 •
edited
Loading

@ceyhun Regarding:

* [x]  🔴 TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites -> **I'm still able to see the option to edit the block and when I press it, it stays stuck in loading.**

This PR made changes how this should be tested. You should now see the option to edit the block with the web editor, and then see the loading screen, but after a time it should land on the "Unable to load the block editor right now" screen (it takes a bit, but it did load for WPAndroid):

screencapture-1626126487008.mp4

@ceyhun
Copy link
Copy Markdown
Contributor Author

ceyhun commented Jul 13, 2021

This PR made changes how this should be tested. You should now see the option to edit the block with the web editor, and then see the loading screen, but after a time it should land on the "Unable to load the block editor right now" screen (it takes a bit, but it did load for WPAndroid):

Just tried on WPiOS and indeed after a while it shows the Unable to load the block editor right now screen 👍 I created a PR to update this test case: wordpress-mobile/test-cases#85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AmandaRiu AmandaRiu AmandaRiu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-process

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.