Add error boundary components and exception logging#6655
Merged
Conversation
This was referenced Feb 20, 2024
[Gutenberg] Add error boundary components and exception logging
wordpress-mobile/WordPress-iOS#22655
Merged
# Conflicts: # gutenberg # ios-xcframework/XCFrameworkScaffold.xcodeproj/project.pbxproj
fluiddot
changed the title
2 tasks
fluiddot
commented
Feb 26, 2024
|
|
||
| if [[ -n "$BUILDKITE_TAG" ]]; then | ||
| echo "--- :arrow_up: Upload Android source map" | ||
| node gutenberg/node_modules/react-native/scripts/compose-source-maps.js bundle/android/App.text.js.map bundle/android/App.js.map -o bundle/android/App.composed.js.map |
Contributor
Author
There was a problem hiding this comment.
The composed source map is now generated as part of the bundle npm command.
14 tasks
13 tasks
# Conflicts: # gutenberg # package.json
Closed
13 tasks
jhnstn
approved these changes
Mar 7, 2024
Member
jhnstn
left a comment
jhnstn
left a comment
There was a problem hiding this comment.
The changes look good and the iOS test build works as expected.
I know we still need to test with an Android build but unless anything changes, this looks ready to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Closes #1187 (comment).
The changes coming from Gutenberg enable the error boundary at the editor and block level. As well as provide a bridge function to log JavaScript exceptions to the Crash Logging service used in the host apps.
Additionally, this PR includes the following changes:
To test
Since it involves testing exceptions, we need to modify the code to force errors and generate an installable build. A test PR has been created for this purpose, follow the testing instructions from #6654.
PR submission checklist: