[codex] harden winit platform backends#31
Draft
ola-893 wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens the winit shell against missing or non-AppKit native window handles.
Why
The shell previously assumed AppKit handles in places that can be reached by cross-platform or background/test shell paths. That made platform integration brittle and could panic instead of falling back to deterministic mock behavior.
Impact
Desktop/macOS behavior continues to use native backends when an AppKit view exists. Other paths now degrade to mock backends instead of crashing.
Validation
cargo test -p fission-shell-winit --lib --locked -- --nocapture