[codex] add optional bundled fonts for theme and skia#34
Draft
ola-893 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds optional bundled font support for the theme crate and cleans up the dormant Skia renderer path.
bundled-fontsfeature10000.0text layout fallbacks in Skiafission-renderFill and Stroke typesWhy
The theme crate embedded font assets unconditionally, and Skia had a large magic width fallback for unconstrained text. The Skia crate was also commented out of workspace members but not excluded, which prevented direct manifest checks.
Impact
Default consumers keep current bundled-font behavior. Consumers that disable default features can avoid embedding theme font bytes, while Skia can still construct a fallback typeface.
Validation
cargo check -p fission-theme --locked --offlinecargo check -p fission-theme --no-default-features --locked --offlinecargo check -p fission-shell-winit --lib --lockedcargo check --manifest-path crates/rendering/fission-render-skia/Cargo.toml