This repository was archived by the owner on May 18, 2022. It is now read-only.
Open
Conversation
gcnit
reviewed
Oct 4, 2019
| */ | ||
| public class Balance { | ||
|
|
||
| Map<Integer, Double> pay; |
gcnit
reviewed
Oct 4, 2019
|
|
||
| public void split(List<User> l1){ | ||
|
|
||
| User PaidByUSer = l1.get(0); |
Collaborator
There was a problem hiding this comment.
public void split(List users) {
User paidByUser = users.get(0);
gcnit
reviewed
Oct 4, 2019
| super(amount); | ||
| } | ||
|
|
||
| public void split(List<User> l1){ |
Collaborator
There was a problem hiding this comment.
better variable name?
users?
gcnit
reviewed
Oct 4, 2019
| public void split(List<User> l1){ | ||
|
|
||
| User PaidByUSer = l1.get(0); | ||
| double divamount = getAmount()/l1.size(); |
gcnit
reviewed
Oct 4, 2019
| SHOW | ||
|
|
||
| */ | ||
| public static void main(String[] args) { |
Collaborator
|
@rkyadaviitkgp sorry for the delay! Was busy at work. Code looks good! Need to work on variable names. Also instead of keeping balances at the user level, better to keep it at a central place. Gave a few comments. Please check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.