Skip to content
This repository was archived by the owner on May 18, 2022. It is now read-only.

solved the problem#16

Open
iamdeepti wants to merge 3 commits intoworkattech:masterfrom
iamdeepti:master
Open

solved the problem#16
iamdeepti wants to merge 3 commits intoworkattech:masterfrom
iamdeepti:master

Conversation

@iamdeepti
Copy link
Copy Markdown

No description provided.

@gcnit
Copy link
Copy Markdown
Collaborator

gcnit commented Oct 28, 2019

Hi @iamdeepti I looked at your code.

As mentioned in the previous PR, it would be a good idea for you to look at How to prepare for machine coding round? and reattempt this problem or another problem from our practice section.

I'd specifically like to point out these points from the above article based on your code:

  • Each class should have a file of its own.
  • The main method which will be used to test your solution should reside in a Driver class.
  • It is essential to learn how to write proper and self-explanatory variable and method names.

It would be a good idea to self-review your code with the above points and other points mentioned in the article.

You may also want to look at my solution for Design Splitwise - Machine Coding

@iamdeepti
Copy link
Copy Markdown
Author

Thanks for your feedback @gcnit I'll reattempt this problem.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants