Conversation
|
|
||
| public static void main(String[] args) { | ||
| // Initializing ExpenseManager Object | ||
| ExpenseManager expman = new ExpenseManager(); |
There was a problem hiding this comment.
avoid variable names like expman
| } | ||
|
|
||
| public String getMob_no() { | ||
| return mob_no; |
There was a problem hiding this comment.
use either camelCase or underscore_separated. not both. For java, best to go with camelCase
|
Hi @gdsoumya I looked at your code. Code looks good! I've given a few comments that could help make the code better. Both of which are mentioned in our how to prepare article as well. You may also want to look at my solution for Design Splitwise - Machine Coding |
|
Hi @gcnit thank your valuable feedback, I will make the changes as suggested. I looked at your solution it was very modular and clean, I learned a lot. I just have another question, will my solution be acceptable even though it doesn't break the ExpenseManager into further sub modules? |
|
Should be good for an sde1 role. Just keep the code readable. |
|
Thanks. |
2 participants
No description provided.