Conversation
| It keep records from the begining meaning if there is no borrow between the users still we maintain the amount. | ||
| **/ | ||
|
|
||
| public static void printTable(int Matrix[][]) |
There was a problem hiding this comment.
variable name should start with lowercase
|
|
||
| public static void updateTransctionTableEqual(int Matrix[][],String payer, String whom[] , int amount) | ||
| { | ||
| int split_wise = (amount)/whom.length; |
There was a problem hiding this comment.
Either use camelCase or underscore_separated based on the language’s convention. Please do not use both in your solution.
Source: How to prepare for machine coding round?
| updateTransctionTableEqual() method updates the Transaction Matrix on 'EQUAL' option | ||
| **/ | ||
|
|
||
| public static void updateTransctionTableEqual(int Matrix[][],String payer, String whom[] , int amount) |
There was a problem hiding this comment.
Why do you need a 'Table' suffix?
|
@tusharanand29 sorry for the delay in review. I've added a few comments. Please go through How to prepare for Machine Coding Round? I would recommend you to do a self-review from my solution for Splitwise design so as to get a better idea on how to structure your code. You can push again after making the changes for another review. Would recommend you to try the other problems as well. Snake and Ladder Design: https://workat.tech/machine-coding/practice/snake-and-ladder-problem-zgtac9lxwntg |
|
Thank you so much for your valuable guidelines sir.
…On Fri, Feb 21, 2020 at 1:37 AM Gaurav Chandak ***@***.***> wrote:
@tusharanand29 <https://github.com/tusharanand29> sorry for the delay in
review. I've added a few comments. Please go through How to prepare for
Machine Coding Round?
<https://workat.tech/machine-coding/article/how-to-prepare-for-machine-coding-round-naf2ih7a9e5l>
I would recommend you to do a self-review from my solution for Splitwise
design
<https://workat.tech/machine-coding/article/how-to-design-splitwise-machine-coding-ayvnfo1tfst6>
so as to get a better idea on how to structure your code. You can push
again after making the changes for another review.
Would recommend you to try the other problems as well.
Snake and Ladder Design:
https://workat.tech/machine-coding/practice/snake-and-ladder-problem-zgtac9lxwntg
Trello Design:
https://workat.tech/machine-coding/practice/trello-problem-t0nwwqt61buz
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19?email_source=notifications&email_token=AK7Q46YRIJIONEJEVXMJACTRD3PJ7A5CNFSM4J3AYD6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMP4GGA#issuecomment-589284120>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AK7Q466TWYWEGRHZ56OO5WDRD3PJ7ANCNFSM4J3AYD6A>
.
|
2 participants
Please review it
Thanking you
Tushar