This repository was archived by the owner on May 18, 2022. It is now read-only.
Open
Conversation
kashyap2108
reviewed
Sep 23, 2019
| System.out.println("inside equal"); | ||
| splitWiseService.distributeMoneyIfEqual(borrowerList,lender,amount); | ||
| } | ||
| else if(Expensetype.equals("PERCENT")) |
Collaborator
There was a problem hiding this comment.
You can use switch case for better readability of code.
gcnit
reviewed
Sep 28, 2019
| int amount=Integer.parseInt(inputarray[2]); | ||
| int noOfborrowers=Integer.parseInt(inputarray[3]); | ||
| ArrayList<String> borrowerList=new ArrayList<String>(); | ||
| int i=4; |
gcnit
reviewed
Sep 28, 2019
| else if(Expensetype.equals("PERCENT")) | ||
| { | ||
| ArrayList<Integer> percentList=new ArrayList<>(); | ||
| int m=i+2; |
gcnit
reviewed
Sep 28, 2019
| import com.workattech.sw.models.Money; | ||
| import com.workattech.sw.models.User; | ||
|
|
||
| public class PrintService { |
gcnit
reviewed
Sep 28, 2019
|
|
||
| public class PrintService { | ||
|
|
||
| Map<String,ArrayList<Money>> listOfUserWhoOwesToUser; |
gcnit
reviewed
Sep 28, 2019
| public class PrintService { | ||
|
|
||
| Map<String,ArrayList<Money>> listOfUserWhoOwesToUser; | ||
| public void printMoneyOwnedByParticularUser(String user,SplitWiseService splitWiseService) |
Collaborator
There was a problem hiding this comment.
This method is not very readable
gcnit
reviewed
Sep 28, 2019
| ArrayList<User> userList=new ArrayList<User>(); | ||
| CalculateExpense calculateExpense=new CalculateExpense(); | ||
| public Map<String,ArrayList<Money>> listOfUserWhoOwesToUser=new HashMap<>(); | ||
| public Map<String,ArrayList<Money>> getlistOfUserWhoOwesToUser() |
Collaborator
There was a problem hiding this comment.
should use proper camelCase
gcnit
reviewed
Sep 28, 2019
| public void distributeMoneyIfEqual(ArrayList<String> borrowers,String lender,int amount) | ||
| { | ||
|
|
||
| double amountToBeDistributed=calculateExpense.CalculateMoneyEqual(amount,borrowers.size()+1); |
Collaborator
There was a problem hiding this comment.
CalculateMoneyEqual?
Should be calculateMoneyEqual
Collaborator
There was a problem hiding this comment.
same comment for other methods
gcnit
reviewed
Sep 29, 2019
| subtractMoneyFromBorrowers(borrowers.get(i),lender,amountToBeDistributed); | ||
| } | ||
| } | ||
| public void distributeMoneyIfExact(ArrayList<String> borrowers,String lender,ArrayList<Integer> exactShare) |
Collaborator
There was a problem hiding this comment.
instead of exposing multiple methods from here. You could have created a single method like addExpense and taken an expense object as param. And deciding which distribution to choose could be done here
gcnit
reviewed
Sep 29, 2019
| double amount; | ||
| public Money(String moneyGivenBy,String moneyTakenBy,double amount) | ||
| { | ||
| this.personA=moneyGivenBy; |
Collaborator
There was a problem hiding this comment.
Money should not know about who paid to whom. A better name would have been expense
gcnit
reviewed
Sep 29, 2019
| this.amount-=amountTakenBypersonA; | ||
| if(this.amount<0) | ||
| { | ||
| this.amount=0; //No money is owned by personA from personB |
Collaborator
|
@dharani1997 sorry for the delay! Was busy at work. Gave a few comments. Please check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.