This repository was archived by the owner on May 18, 2022. It is now read-only.
Open
Conversation
gcnit
reviewed
Oct 4, 2019
|
|
||
| @Override | ||
| public List<ExpenseLog> splitExpense(String expenseDetails) { | ||
| String[] details = expenseDetails.split(" "); |
Collaborator
There was a problem hiding this comment.
This should not be part of your design. Should have created the expense object and passed here from the main method itself. Parsing the input should not be done here.
gcnit
reviewed
Oct 4, 2019
| private String piadby; | ||
| private String owedBy; | ||
| private double amount; | ||
| public ExpenseLog(String piadby, String owedBy, double amount) { |
Collaborator
|
@shishiruniyal sorry for the delay! Was busy at work. Code looks pretty good! Good enough to crack the round! Gave a few comments. Please check. |
Author
|
Thanks Gaurav for reviewing and feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.