This repository was archived by the owner on May 18, 2022. It is now read-only.
Open
Conversation
gcnit
reviewed
Oct 23, 2019
|
|
||
| // List: Each list should have a id, name and cards | ||
| private List<Card> cards; | ||
| private Board board; |
Collaborator
There was a problem hiding this comment.
why does ListItem have access to the Board?
gcnit
reviewed
Oct 23, 2019
| } | ||
|
|
||
| //We should also be able to move cards across lists in the same board | ||
| public void AddCardToList(Card c){ |
gcnit
reviewed
Oct 23, 2019
| this.board = board; | ||
| } | ||
|
|
||
| public String getPrintableString(){ |
Collaborator
There was a problem hiding this comment.
can be done by overriding toString
gcnit
reviewed
Oct 23, 2019
| Map<String, ListItem> lists; | ||
| Map<String, Card> cards; | ||
|
|
||
| public MockMachineCoding3() { |
gcnit
reviewed
Oct 23, 2019
| */ | ||
| public enum Privacy { | ||
|
|
||
| publicType, privateType; |
Collaborator
There was a problem hiding this comment.
enums are generally written in UPPERCASE
Collaborator
|
Hi @rkyadaviitkgp sorry for the delay in code review. The code looks good. Gave a few comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.