This repository was archived by the owner on May 18, 2022. It is now read-only.
Open
Conversation
gcnit
reviewed
Feb 20, 2020
| // Model for Board | ||
| public class Board { | ||
|
|
||
| private String name, bid, url; |
Collaborator
There was a problem hiding this comment.
got it. Could just be id. bid is not self-explanatory
gcnit
reviewed
Feb 20, 2020
| } | ||
|
|
||
| // Parses the Input, validates the data and calls required functions | ||
| public void handleRequest(String request) { |
Collaborator
There was a problem hiding this comment.
this could be cleaner. You can put the parsing logic before this.
Collaborator
|
@gdsoumya code looks good. Gave a few minor comments. Would recommend you to try the other problems as well. Snake and Ladder Design: https://workat.tech/machine-coding/practice/snake-and-ladder-problem-zgtac9lxwntg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.