Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Remove redundant alias keys (roles, roleAssignments) from DEFAULT_ENTITY_COUNTS and COUNTABLE_FILES. Both roles and roleDefinitions mapped to the same file (role_definitions.csv), causing spurious entity_count_mismatch errors when only one key was set. Similarly, roleAssignments was an alias for the userRoleAssignments file key. Use only canonical keys (roleDefinitions, userRoleAssignments) so each file is validated exactly once. Co-Authored-By: zac.burrage <zac.burrage@workos.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Replace removed alias keys (roles, roleAssignments) with canonical keys (roleDefinitions, userRoleAssignments) in the example manifest. Co-Authored-By: zac.burrage <zac.burrage@workos.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the provider-neutral migration package contract that future provider exporters and import-package orchestration can share.
This includes:
Impact
Existing single-CSV import/export behavior is unchanged. This branch only adds the package foundation and generated dist output.
Stack
This is PR 1 of 3. Merge order:
Bug fix: double-counting entity count aliases
Fixed a bug where
COUNTABLE_FILESandDEFAULT_ENTITY_COUNTScontained alias keys (roles→roleDefinitions,roleAssignments→userRoleAssignments) that mapped to the same underlying CSV file. This causedvalidatePackageCountsto check the same file twice with potentially different expected counts, producing spuriousentity_count_mismatcherrors. The fix removes the aliases and uses only canonical keys. Updated the example manifest in docs accordingly.Validation
Checklist
npm run lint,npm run typecheck,npm run build, andnpm testlocally.Link to Devin session: https://app.devin.ai/sessions/6cb6a67c0a7b4347aea738290e855633
Requested by: @zdburrage