Conversation
…rrency - Add dist/ to .gitignore and untrack the 150 stale build artifacts. The publish workflow rebuilds dist via prepack, and consumers receive a fresh build in the npm tarball — tracking dist only causes merge noise and divergence between source and committed artifacts. - Add `prepare: npm run build` so installs from a git URL still build. - Add concurrency control to publish-npm.yml to prevent racing publishes if two releases trigger simultaneously (matches workos/widgets pattern). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Reference `npm run check` as the single command to run before opening a pull request, mention the additional CI smoke and package dry-run steps, and bump the documented Node.js requirement to `>=22.11.0` to match `engines` in package.json.
Resolve conflicts caused by untracking `dist/` on this branch while `main` continued to update generated artifacts. dist/ is now ignored and rebuilt by `prepack`/`prepare`, so all dist conflicts are resolved by removing the files.
Collaborator
Author
|
Holding off to put this logic into the main CLI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publish-npm.yml) modeled on theauthkit-tanstack-startpattern Nick Nisi set up org-widedocs/releasing.md(one-time setup, public-repo readiness checklist, version-tag rule)bin,files,publishConfig,prepack/prepublishOnly/preparescripts,npm pack --dry-runsmoke checkdist/(150 stale artifacts) and add to.gitignore— workflow rebuilds dist on publish viaprepackworkos/widgets) so simultaneous releases can't raceWhy
WorkOS migrated all TS SDKs to npm Trusted Publishers in early 2026 after npm killed long-lived tokens. This brings
workos-migrationsonto that pattern so we can publish to npm and shipnpx workos-migrations@latestper the plan in #proj-smoother-migrations.What still needs to happen externally
These can't be done from a PR — needs npm org admin:
workos-migrationson npmpublish-npm.yml, environment:npm)npmenvironment with required reviewers (manual approval gate)Test plan
npm run buildsucceeds and regeneratesdist/npm run smoke:bin(CLI--help) renders correctlynpm run package:dry-runshows expected tarball contents (153 files, 98.1 kB)npm run checkpasses (lint + format + typecheck + 229 tests + build)Notes for review
workos/widgets(pnpm workspace, multiple packages, frequent releases) but overkill here.workflow_dispatchbecause the tag-vs-version check enforces correctness.🤖 Generated with Claude Code