fix: explicit license & drop siwe package#30
Conversation
paolodamico
commented
May 13, 2026
paolodamico
commented
- We don't need the SIWE package, viem already ships with that functionality. This lets us drop all the ethers peer deps.
- Adds explicit license information to all packages.
paolodamico
requested review from
Takaros999,
andy-t-wang and
m1guelpf
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b80e537ff8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| issuedAt: info.issuedAt, | ||
| expirationTime: info.expirationTime, | ||
| notBefore: info.notBefore, | ||
| issuedAt: new Date(info.issuedAt), |
There was a problem hiding this comment.
Do not coerce SIWE timestamp fields through Date here: new Date(info.issuedAt) (and the optional fields below) normalizes the original text, so the reconstructed SIWE message can differ from what the client signed (for example when issuedAt is a plain string without timezone). This commit makes that mismatch possible because isAgentkitExtension only enforces that issuedAt is a string (x402/src/client.ts), not a canonical RFC3339 value, and signature verification depends on byte-for-byte message equality.
Useful? React with 👍 / 👎.
Takaros999
left a comment
Takaros999
left a comment
There was a problem hiding this comment.
please sanity check PR comment by Codex
2 participants
