fix: restore pull_request_target for fork PR secrets access #29
Conversation
🤖 Worlddriven Status📊 Live Status Dashboard🗓️ Merge Date: 2026-01-25 at 07:33:04 UTC (in 1 day) 🎯 Want to influence when this merges?Your review matters! As a contributor to this project, your voice helps determine the merge timeline. How to review:
Your options:
💡 Pro tip: The more contributors who agree, the faster this gets merged! 📊 View detailed stats on the dashboard 📋 Recent Activity• 2026-01-24, 08:30:46 - Pull request opened This comment is automatically updated by worlddriven |
TooAngel
force-pushed
the
fix/restore-pull-request-target
branch
from
743ad4c to
5a810db
Compare
The workflow was accidentally regressed to use pull_request instead of pull_request_target when PR worlddriven#3 was squash merged. This prevented fork PRs from accessing repository secrets needed for the migrate app authentication. Changes: - Restore pull_request_target trigger - Add sparse checkout of REPOSITORIES.md from PR - Keep trusted scripts from main branch for security - Maintain MIGRATE_APP_ID/PRIVATE_KEY env vars from PR worlddriven#28
TooAngel
force-pushed
the
fix/restore-pull-request-target
branch
from
5a810db to
6bd8597
Compare
1 participant
Summary
Restores the
pull_request_targettrigger that was accidentally lost when PR #3 was squash merged. This is required for fork PRs to access repository secrets needed for the migrate app authentication.Problem
PR #27 (migration test) was failing because the workflow couldn't access
MIGRATE_APP_IDandMIGRATE_APP_PRIVATE_KEYsecrets. The secrets exist but weren't being passed to the workflow becausepull_requestdoesn't provide secrets to fork PRs.Solution
Restore the original security model from commit d7de949:
pull_request_targetto run workflow in base repository context (secrets available)This maintains security while allowing fork PRs to work.
Test Plan