Draft
Conversation
Owner
|
Hey @jameskentdev, thanks for working on this. I don't want to add a dependency for this, though. Could you find another way to implement this? |
…filter, this breaks the identify_by_fields logic
… it must be supplied
Author
|
I took a look at some other approaches in jameskentdev#1, I'm still working on finishing it up. Just for arguments sake I did also add the last few changes here to get it all working with this dependency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is the start of adding support for filtering with
ORinstead of onlyANDas mentioned in the docs. The solution is the one proposed in #415, which introduces a new type as follows:The changes focus on just introducing the new type, and adding support for it inside
Flop.Validate.To get this to work, I introduced a new library - polymorphic_embed. This makes it easier to support filters containing either a
Filteror aCombinatortype.