Skip to content

Conversation

@ahuseyn
Copy link
Member

@ahuseyn ahuseyn commented Jan 19, 2026

Description

This pull request adds comprehensive end-to-end (E2E) tests for the integration between the HWP Previews plugin and Advanced Custom Fields (ACF), and introduces supporting utilities to automate ACF plugin management and custom post type creation in tests.

New ACF Integration E2E Tests:

  • Added a new E2E test suite acf-integration.spec.js to verify that custom post types created via ACF are correctly recognized and handled by the HWP Previews plugin. This includes:
    • Verifying ACF custom post types appear as tabs in the HWP Previews settings and have the expected settings fields.
    • Ensuring HWP preview logic (including preview links and iframe previews) works correctly for ACF custom post types.
    • Automated setup and teardown of ACF post types and plugin state for reliable, isolated testing.

Related Issue

Dependant PRs

Type of Change

  • ✅ Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactoring (no functional changes)
  • 📄 Example update (no functional changes)
  • 📝 Documentation update
  • 🔍 Performance improvement
  • 🧪 Test update

How Has This Been Tested?

Screenshots

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the project's coding standards
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Any dependent changes have been highlighted, merged or published

@ahuseyn ahuseyn requested a review from a team as a code owner January 19, 2026 13:23
@changeset-bot
Copy link

changeset-bot bot commented Jan 19, 2026

⚠️ No Changeset found

Latest commit: 6147cec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ahuseyn ahuseyn requested a review from josephfusco January 19, 2026 13:23
@github-actions
Copy link

📦 Plugin Artifacts Ready!

Download from GitHub Actions run

Available plugins:

  • ✅ hwp-previews.zip

See the "Artifacts" section at the bottom of the Actions run page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants