Skip to content

fix: update query params to get latest reviews #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
con322 wants to merge 1 commit into
base: demo
Choose a base branch
from
+11 −7
Open

fix: update query params to get latest reviews #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/index.asset.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<?php return array('dependencies' => array('wp-core-data', 'wp-data', 'wp-dom-ready', 'wp-editor', 'wp-hooks'), 'version' => '0b5dcdea2863edd9e538');
<?php return array('dependencies' => array('wp-core-data', 'wp-data', 'wp-dom-ready', 'wp-editor', 'wp-hooks'), 'version' => 'ffc86fc3d064c91ef82e');
2 changes: 1 addition & 1 deletion build/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 9 additions & 5 deletions src/review-workflow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,12 @@ addFilter('mediaPress.checklist.item', 'mediaPress/starterPlugin/checkApprovedRe

const postId = select(editorStore).getCurrentPostId();
const reviews = select(coreStore).getEntityRecords('root', 'comment', {
post: postId,
type: COMMENT_TYPE,
per_page: -1,
parent: 0,
post: postId,
type: COMMENT_TYPE,
per_page: -1,
parent: 0,
orderby: 'date',
order: 'desc',
});

// If reviews haven't loaded yet, show as blocking until resolved.
Expand Down Expand Up @@ -76,11 +78,13 @@ async function updateWorkflowStatusAfterReview(review) {

// Get all top-level reviews for this post.
const postId = select(editorStore).getCurrentPostId();
const reviews = await select(coreStore).getEntityRecords('root', 'comment', {
const reviews = await resolveSelect(coreStore).getEntityRecords('root', 'comment', {
post: postId,
type: COMMENT_TYPE,
per_page: -1,
parent: 0,
orderby: 'date',
order: 'desc',
});

if (!reviews || reviews.length === 0) {
Expand Down