This repository was archived by the owner on Oct 22, 2020. It is now read-only.
Add design doc for CommandStateMachine.#4
Open
PeterJohnson wants to merge 1 commit intowpilibsuite:masterfrom
Open
Add design doc for CommandStateMachine.#4PeterJohnson wants to merge 1 commit intowpilibsuite:masterfrom
PeterJohnson wants to merge 1 commit intowpilibsuite:masterfrom
Conversation
PeterJohnson
force-pushed
the
command-state-machine
branch
2 times, most recently
from
c45619d to
9906458
Compare
Member
Author
|
Inner classes are a little uglier in C++. It's certainly possible to build more complex constructs with CommandGroup and ConditionalCommand, but I think the result is more difficult to follow, doesn't address some of the underlying limitations (eg. rejoining or more complex n-ary branching behavior), and doesn't lend itself as easily to automatic code generation (e.g. from RobotBuilder). |
PeterJohnson
force-pushed
the
command-state-machine
branch
from
9906458 to
dc39cb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is