W-426: scope stats feature-usage to real features + add Quick Access metrics + telemetry lint#140
Merged
Merged
Conversation
…metrics The stats pipeline had drifted: the worker ingested 13 feature keys but the public page only labelled 9, so the per-mode trigger flags rendered as raw camelCase, and minutiae (Require ::, Arrow conversion) showed as full tiles. Decouple ingest from publish — keep ingesting everything for the debug view, but curate the published set (PUBLIC_FEATURE_KEYS) to the features that matter, in a stable order. Add coverage that was missing: the emoji trigger (now disableable), an "any trigger customized" rollup, and the easter-egg master switch. New Quick Access depth: a daily-active signal (a pick from the favorites pill), favorites-pinned adoption, and a top-favorites histogram (hexcodes only, same privacy posture as top emoji). check_telemetry.py + a CI workflow (parallel to the i18n check) fail the build when the three telemetry layers drift, so "added a feature, forgot the stats" can't ship silently. Worker deploy + `npm run db:init:remote` needed for the new tables/logic. Refs: W-426
Contributor
|
🤖 pr-review skipped — this PR modifies |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Brings the anonymous-stats pipeline back in sync and scopes the public Feature Usage to features that matter.
Feature coverage
FEATURE_KEYSkeeps everything (debug view), a curated/orderedPUBLIC_FEATURE_KEYSis what the page shows.Quick Access metrics
quickAccessinsertion total + aquickAccessActivedaily-active tick (a pick from the favorites pill).favoritesCountdistribution → favorites-pinned adoption.favorite_dailytop-favorites histogram (hexcodes only, same privacy posture as top emoji).Telemetry lint
scripts/check_telemetry.py+.github/workflows/telemetry.ymlfail the build when the Swift client / worker ingest / published set drift. Parallel to the i18n check.Test plan
scripts/run-tests.sh✓node --check+ mock-D1 smoke test ✓ (QA DAU & favorites math, curated ordering, bad-hex rejection)python3 scripts/check_telemetry.py✓ (incl. in-memory drift detection)Deploy notes
npm run deploy+npm run db:init:remote(addsfavorite_daily; idempotentCREATE IF NOT EXISTS).Refs W-426