W-436: Trigger picker fixes — Quick Access ?, glyph-only labels, custom field#151
Merged
wr merged 3 commits intoJun 26, 2026
Conversation
…om field - Quick Access opens carry the `?` marker everywhere: the picker shows/sets presets as `<char>?` (`#` → `#?`), and normalize() appends `?` to any non-follow Quick Access open (migrating existing bare configs). The `?` is what the state machine's pill / escape-restore keys off. - Drop the "Colon"/"Semicolon"/… names from the trigger dropdowns; options show just the glyph. The Quick Access menu also hides the preset that would duplicate the "follow emoji" row (`:` → `:?`). - Restyle the "Custom…" trigger field to match the global-shortcut recorder box (rounded field, native input look, clear button, accent border while editing) while keeping free-text entry. Refs: W-436
- "<X> shortcut" → "<X> trigger" on the trigger rows. - "Emoji Browser" → "Emoji Browser shortcut". - Globe toggle: "Open with the 🌐 key" → "Press 🌐 key to open Mojito". - Drop the "Easter eggs still play on screen…" footer. Refs: W-436
fzy (the fuzzy-match scoring algorithm FzyScorer ports) and GIPHY (GIF search; their API terms require attribution). Refs: W-436
wr
deleted the
wells/w-436-trigger-picker-fixes-quick-access-marker-glyph-only-labels
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes to the shared trigger picker (Settings ▸ General).
What's in it
?marker — Quick Access opens are<char>?(the trailing?is what the state machine's pill / escape-restore keys off, viaquickAccessRestoreChar = qa.open.last). The picker now shows/sets presets as<char>?(#→#?), andnormalize()appends?to any non-follow Quick Access open — migrating existing bare configs (#→#?).:→:?).Test plan
:?(follow),;?,/?,!?,#?; no human names; no duplicate:?.<char>?; existing bare configs migrate on load.?).normalize()non-follow test).Review
Independent code review: no high-confidence issues. Confirmed
?-suffix consistency acrossnormalize(), the matcher, the state machine, the picker (value/label/disabled/customModeseeding), and the Esc-restore path; no regression for the non-Quick-Access modes.Refs W-436