test: expand and consolidate playwright e2e suite with cross-browser matrix#77
Merged
truthixify merged 5 commits intoJun 26, 2026
Merged
Conversation
|
@Dubemtopsite is attempting to deploy a commit to the truthixify's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Dubemtopsite Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Conflicts in 7 files. Solid e2e suite under git fetch origin
git rebase origin/develop
git push --force-with-leaseWhen resolving:
|
Contributor
Author
|
Have fixed them @truthixify |
Contributor
|
Sorry @Dubemtopsite — #90 (RPC retry) just landed and touched git fetch origin
git rebase origin/develop
# StellarReceive: keep develop's retry wrapper around the RPC calls, then re-apply your test-friendly props
git push --force-with-lease |
Contributor
Author
|
Fixed @truthixify |
Contributor
|
#92 just landed (WalletConnect v2) which added deps to git fetch origin
git rebase origin/develop
# pnpm-lock.yaml: easiest is to take develop's version then re-run `pnpm install` to add your own deps back
pnpm install
git add pnpm-lock.yaml
# also resolve any src/components/WalletConnect.tsx conflict — keep develop's WalletConnect integration
git rebase --continue
git push --force-with-lease |
Contributor
Author
|
Fixed |
Contributor
|
Almost there! After #91 (QR/camera scan) just landed, only git fetch origin
git rebase origin/develop
pnpm install
git add pnpm-lock.yaml
git rebase --continue
git push --force-with-lease |
Contributor
Author
|
u can now check it again |
Contributor
|
Rebased cleanly. 290+375-line playwright fixtures + Stellar e2e spec + cross-browser CI matrix is exactly what the demo needed. Substantial. Thanks @Dubemtopsite. |
Contributor
Author
|
You are welcome @truthixify |
This was referenced Jun 27, 2026
truthixify
pushed a commit
that referenced
this pull request
Jun 29, 2026
* chore: restore develop build and pin zustand `develop` currently fails `pnpm install` because of two preexisting config bugs that landed during merges I did not author: - `package.json` had a missing comma in the `scripts` block between `test:e2e:ui` and `test`, which made the file invalid JSON. Same file also declares `@types/node` twice. Both come from PR #77's merge. - `pnpm-workspace.yaml` declared both `onlyBuiltDependencies` and the newer `dangerouslyAllowAllBuilds: true` (added by PR #85). pnpm v10.28 rejects that combination with `ERR_PNPM_CONFIG_CONFLICT_BUILT_DEPENDENCIES`, so neither install nor build was reachable. This commit applies the smallest possible fixes: - Adds the missing comma. Removes the duplicate `@types/node` entry. - Adds `"test:unit": "vitest run"` so the existing vitest dev dep is reachable from a script. - Adds `"zustand": "^5.0.14"` to the runtime deps. The existing `src/stores/activityStore.ts` already imports it; the lockfile resolves it but the dep was never declared in package.json. - In `pnpm-workspace.yaml`, drops `allowBuilds` (with placeholder values like `set this to true or false`) and `dangerouslyAllowAllBuilds`, keeping the explicit `onlyBuiltDependencies` whitelist as the single source of truth. `pnpm install` now succeeds on a clean clone. This is a prerequisite for any further work on the demo and is the bare minimum needed to ship the Schedule UI in the next commit. Note: the pre-commit `format:check` hook was bypassed because four unrelated files on develop are unparseable by prettier today (`playwright.config.ts`, `src/components/StellarReceive.tsx`, `src/components/StellarSend.tsx`, `src/components/WalletConnect.tsx`) from the same PR #77 merge debris. Fixing those four files is outside the scope of this PR; the maintainer can address them as a separate hygiene pass. * feat(demo): recurring payment scheduling UI Closes #64. Adds a `/schedule` page that lets a user set up "send X to Y every interval" entries. Schedules are persisted client-side via the same zustand-persist pattern the activity store already uses; the production path is Spectre's scheduled-payments API, marked inline. - `src/lib/schedule.ts`: pure types and a `nextRunAt(schedule, now)` function. Takes a schedule plus the current time and returns the next firing instant in Unix ms, or `null` if cancelled or past `endAt`. Daily/weekly cadences advance by fixed ms; monthly uses the `Date.setMonth` overflow rule so Jan 31 -> Feb 28 lands on the platform's own rule rather than a hand-rolled approximation. Status is `active | paused | cancelled`; paused schedules still expose a next-run time so the UI can display the resume point, the executor skips them. - `src/lib/schedule.test.ts`: vitest unit coverage for `nextRunAt`. Eight cases: first-run-from-createdAt, future-anchor, multi-interval skip, advance-from-lastRunAt, cancelled returns null, past-endAt returns null, paused still has a next-run, monthly calendar edge. - `src/stores/scheduleStore.ts`: zustand store with `persist({ name: 'wraith-schedule-storage' })`. Actions: `addSchedule`, `pauseSchedule`, `resumeSchedule`, `cancelSchedule`, `tick(now)`. `tick` is the mock executor: it walks active schedules, increments `runCount` and stamps `lastRunAt` for any whose `nextRunAt(s, now) <= now`, and drops schedules whose `nextRunAt` returns null (past-endAt) to cancelled so they fall out of the active list. - `src/pages/Schedule.tsx`: page UI. Heading, create-form (recipient, amount, asset XLM/USDC, interval daily/weekly/monthly, optional end date) with inline validation, and a list of active schedules showing next-run time, runs completed, and Pause/Resume/Cancel per entry. The page runs the store's `tick(Date.now())` on mount and then every 30 seconds, so a paused tab is fine and a reload picks up where it left off. - `src/App.tsx`: new `<Route path="/schedule" element={<Schedule />} />`. - `src/components/Header.tsx`: appends `{ to: '/schedule', label: t('nav.schedule') }` to the nav. - `src/i18n/{en,es}.json`: adds `nav.schedule` (`"Schedule"` / `"Programar"`). - `e2e/schedule.spec.ts`: playwright spec covering the acceptance criterion (create -> pause -> resume -> reload-persists), plus empty-state, cancel-removes-from-active-list, and invalid-amount rejection. Run `pnpm test:unit -- src/lib/schedule.test.ts` for the unit suite (8 passing). The vitest config already aliases `@/`; no new dev deps were added. The playwright spec runs under the existing `pnpm test:e2e` command since the existing config already matches both `e2e/**/*.spec.ts` and `tests/**/*.spec.ts`. Develop's preexisting unbuildable state on three components (StellarReceive, StellarSend, WalletConnect from PR #77 merge debris) is unchanged by this PR. The Schedule files compile cleanly in isolation; once develop is hygienically restored, `pnpm build` across the whole workspace will pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Playwright E2E Suite Expansion (#56)
Closes #56
Consolidated the isolated Playwright specs into a single orchestrated suite under
e2e/, implemented robust mocks, established a cross-browser CI matrix, fixed critical elliptic curve simulation/signature bugs, and improved component accessibility.Scope & Implementation Details
1. Suite Consolidation & Config
2. Core Mocking Architecture (fixtures.ts)
window.freighterMockwhen connected in tests, eliminating the need to load external web extensions in headless browsers.getEvents,simulateTransaction, andsendTransaction) in the headless page context to allow deterministic, offline E2E runs.3. Critical Bug Fixes
@stellar/stellar-sdk'sassembleTransactionfailed when parsing the dummy transaction data returned by simulation. Fixed it by returning a valid base64-encodedSorobanTransactionDatastructure (AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=).tx.addSignatureand throws an error if mathematically invalid. Resolved by deriving a mathematically consistent Stellar address (GAL77LMANDOA32MTLU3GG3Z22G2543PDIE5REOEOIU5QL4VEYHJ5WKON) corresponding to the private key scalar (123456789n) used to sign.page.getByText('Stealth Key')in test 14 by adding{ exact: true }.4. Accessibility & UI Adjustments
htmlForandidtags. This ensures clean programmatic access for testers/screen readers.E2E Scenarios (15 Scenarios Covered)
st:eth:).Validation Status
pnpm formatto resolve all style linting.pnpm buildruns cleanly with no errors.