Fix resolving current working directory#45
Open
vladimyr wants to merge 3 commits into
Open
Conversation
bjorn
reviewed
Jun 16, 2020
Define `WREN_PATH_MAX` recursively using `PATH_MAX` or use fallback. Handle `UV_ENOBUFS` error.
vladimyr
force-pushed
the
fix-process.cwd
branch
from
542bdea to
9a43ee6
Compare
bjorn
reviewed
Jun 16, 2020
Remove platform specific check.
vladimyr
force-pushed
the
fix-process.cwd
branch
from
94a187f to
4e701c3
Compare
Contributor
|
What is the case when the path is longer than 4096 characters? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define
WREN_PATH_MAXrecursively usingPATH_MAXor use a fallback.Handle
UV_ENOBUFSerror (provided buffer is too small to store resolved path).