Conversation
modified: Registry/Registry.EM_COMMON modified: arch/Externals.cfg modified: dyn_em/module_first_rk_step_part1.F modified: main/depend.common modified: phys/CMakeLists.txt modified: phys/Makefile modified: phys/module_bl_gwdo.F modified: phys/module_bl_shinhong.F modified: phys/module_pbl_driver.F modified: phys/module_physics_init.F modified: phys/module_sf_sfclayrev.F modified: phys/module_surface_driver.F
|
@weiwangncar can you post the error message? |
|
@Songyou184 we prefer new options to be committed separately. Do you have a way to make this into two commits? |
|
Jimy
To do speprate commitments is a little tedious technically.
Evaluation of each component can be effectively done with less
difficulties, I guess.
2026년 1월 19일 (월) 오후 2:00, dudhia ***@***.***>님이 작성:
… *dudhia* left a comment (wrf-model/WRF#2275)
<#2275 (comment)>
@Songyou184 <https://github.com/Songyou184> we prefer new options to be
committed separately. Do you have a way to make this into two commits?
—
Reply to this email directly, view it on GitHub
<#2275 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVR3U6TV6X5ROJ4DQVE3FBD4HVAVTAVCNFSM6AAAAACR3A56SCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTONZQGEYDGOJTGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@Songyou184 I agree. Too many files have changes for both. |
modified: Externals.cfg
|
Evaluation of the two GWDO and PBL updates could be made in order..
|
Minor change 1.
Minor change for testing.
try testing-branch for a test.
|
|
||
| $(LIBTARGET) : | ||
| (cd .. && ./tools/manage_externals/checkout_externals --externals ./arch/Externals.cfg) | ||
| (./../tools/manage_externals/checkout_externals --externals ./../arch/Externals.cfg) |
There was a problem hiding this comment.
This is a test, and matches what's done in Externals.cfg.
arch/Externals.cfg
Outdated
| protocol = git | ||
| repo_url = https://github.com/NCAR/MMM-physics.git | ||
| tag = 20240626-MPASv8.2 | ||
| branch = testing-branch |
There was a problem hiding this comment.
@islas @Songyou184 Can this be converted to a submodule call as a test, even though this is not the final version for the PR?
|
Looks like this has not passed tests but I am not seeing the submodule implementation yet. |
|
The submodule change is there (for me it shows as the last diff on the "Files changed" page) but since I merged I think we'll have to wait for @weiwangncar to see the error log since I don't get emails for PRs that aren't mine. |
|
OK, I saw that Externals.cfg was still in the Makefile, but maybe I am not seeing what was tested. |
TYPE: Enhancement
KEYWORDS: Revised GWDO and SHINHONG PBL schemes, as in the updates in MPAS
SOURCE: Songyou Hong (NCAR)
DESCRIPTION OF CHANGES:
YSU GWDO was revied following the study of Hong et al. (2025, WAV), now is icalled as KIM GWDO
KIM GWDO requires additional maximum orography file, "ELVMAX", in WPS
Non-hydrostatic effect of Xu et al. (2024, JAS) was added (gwd_if_nonhyd=.true., default)
Factor for the effective grid spacing was added (gwd_dx_factor=2.0, default)
Tutbulent form drag (TOFD) was added in computing surface drag (kim_tofd=.true., default)
Factor for TOFD was added (tofd_factor=.003, default)
SHINHONG PBL was updated
Problem: SHINHONG PBL occasionally was crashed in global models
Solution: Entrainment ratio and depth at the PBL top were reformulated. Topdown mixing, orographic drag, and
building canopy moduels in the YSU PBL were revised and incorporated into revised the SHINHONG scheme. In the revised scheme, one can select nonlocal mixing flux term: either counter-gradient (YSU type) or eddy-mass flux (SHINHONG type). In the namelist,
YSU scheme
Remarks : PHYSICS_MMM is pointed to a personal site, https://github.com/Songyou184/WRF.git -b GWDO_SH
LIST OF MODIFIED FILES: list of changed files (use
git diff --name-status masterto get formatted list)modified: Registry/Registry.EM_COMMON
modified: arch/Externals.cfg
modified: dyn_em/module_first_rk_step_part1.F
modified: main/depend.common
modified: phys/CMakeLists.txt
modified: phys/Makefile
modified: phys/module_bl_gwdo.F
modified: phys/module_bl_shinhong.F
modified: phys/module_pbl_driver.F
modified: phys/module_physics_init.F
modified: phys/module_sf_sfclayrev.F
modified: phys/module_surface_driver.F