Open
Conversation
added temperature and moisture tendency variables only
Collaborator
|
@weiwangncar please check on the failure. |
The make build does not support CFBM but to allow backward compatibility it will be stubbed out. To use the CFBM mode for fire users must compile using the CMake build.
Collaborator
|
The results of regression tests: |
dudhia
previously approved these changes
Feb 5, 2026
Collaborator
dudhia
left a comment
There was a problem hiding this comment.
Code is isolated by ifdefs, so it looks safe.
Collaborator
|
Since it is ifdef'd, how is this to be compiled. Could a note be added on that? |
weiwangncar
previously approved these changes
Feb 19, 2026
weiwangncar
approved these changes
Feb 20, 2026
dudhia
approved these changes
Feb 20, 2026
Collaborator
dudhia
left a comment
There was a problem hiding this comment.
probably needs review from @weiwangncar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: new feature
KEYWORDS: Community Fire Behavior Model, CFBM, fire behavior, fire atmosphere coupling
SOURCE: Pedro A. Jimenez and Masih Eghdami
DESCRIPTION OF CHANGES:
A new fire behavior model, the Community Fire Behavior Model (CFBM, https://gmd.copernicus.org/preprints/gmd-2024-124/gmd-2024-124.pdf) is added.
The model runs with MPI compilation, just one mpi task for the moment, and also in hybrid compilation MPI+OpenMP (only one MPI task for the moment).
To compile the model with the CFBM enabled compile with CMake (
./configure_new) and use-DENABLE_CFBM=ONas part of the cmake forwarded options or go through the prompts of./configure_newand selectENABLE_CFBM.TESTS CONDUCTED:
RELEASE NOTE: Coupling the Community Fire Behavior model (Jimenez y Munot et al., 2024): https://gmd.copernicus.org/preprints/gmd-2024-124/gmd-2024-124.pdf