Skip to content

Comments

Community Fire Behavior Model#2279

Open
islas wants to merge 36 commits intodevelopfrom
fire_cfbm_integration
Open

Community Fire Behavior Model#2279
islas wants to merge 36 commits intodevelopfrom
fire_cfbm_integration

Conversation

@islas
Copy link
Collaborator

@islas islas commented Jan 27, 2026

TYPE: new feature

KEYWORDS: Community Fire Behavior Model, CFBM, fire behavior, fire atmosphere coupling

SOURCE: Pedro A. Jimenez and Masih Eghdami

DESCRIPTION OF CHANGES:
A new fire behavior model, the Community Fire Behavior Model (CFBM, https://gmd.copernicus.org/preprints/gmd-2024-124/gmd-2024-124.pdf) is added.

The model runs with MPI compilation, just one mpi task for the moment, and also in hybrid compilation MPI+OpenMP (only one MPI task for the moment).

To compile the model with the CFBM enabled compile with CMake (./configure_new) and use -DENABLE_CFBM=ON as part of the cmake forwarded options or go through the prompts of ./configure_new and select ENABLE_CFBM.

TESTS CONDUCTED:

  1. CFBM was compared with the existing fire behavior modeling producing similar results when models are configured in a similar manner. Bit for bit results when changing the number of OpenMP threads.

RELEASE NOTE: Coupling the Community Fire Behavior model (Jimenez y Munot et al., 2024): https://gmd.copernicus.org/preprints/gmd-2024-124/gmd-2024-124.pdf

islas and others added 30 commits October 16, 2024 14:56
added temperature and moisture tendency variables only
@islas islas requested review from a team as code owners January 27, 2026 19:47
@dudhia
Copy link
Collaborator

dudhia commented Jan 28, 2026

@weiwangncar please check on the failure.

The make build does not support CFBM but to allow
backward compatibility it will be stubbed out. To
use the CFBM mode for fire users must compile using
the CMake build.
@weiwangncar
Copy link
Collaborator

The results of regression tests:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

dudhia
dudhia previously approved these changes Feb 5, 2026
Copy link
Collaborator

@dudhia dudhia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is isolated by ifdefs, so it looks safe.

@dudhia
Copy link
Collaborator

dudhia commented Feb 12, 2026

Since it is ifdef'd, how is this to be compiled. Could a note be added on that?

weiwangncar
weiwangncar previously approved these changes Feb 19, 2026
Copy link
Collaborator

@dudhia dudhia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably needs review from @weiwangncar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants