Skip to content

Comments

SFCLAY 2026 : # 1 of GWDO-SHPBL PR#2284

Open
Songyou184 wants to merge 3 commits intowrf-model:developfrom
Songyou184:SFCLAY2026
Open

SFCLAY 2026 : # 1 of GWDO-SHPBL PR#2284
Songyou184 wants to merge 3 commits intowrf-model:developfrom
Songyou184:SFCLAY2026

Conversation

@Songyou184
Copy link

@Songyou184 Songyou184 commented Feb 19, 2026

TYPE: new feature

KEYWORDS: surface layer, drag

SOURCE: Songyou Hong

DESCRIPTION OF CHANGES:
Problem:
Generally or specifically, what was wrong and needed to be addressed?

Solution:
What was down algorithmically and in the source code to address the problem?

LIST OF MODIFIED FILES: list of changed files (use git diff --name-status master to get formatted list)
M arch/Externals.cfg
M dyn_em/module_first_rk_step_part1.F
M phys/module_sf_sfclayrev.F
M phys/module_surface_driver.F

TESTS CONDUCTED:

  1. Do mods fix problem? How can that be demonstrated, and was that test conducted?
  2. The Jenkins tests are all passing.

RELEASE NOTE: Include a stand-alone message suitable for the inclusion in the minor and annual releases. A publication citation is appropriate.

 	modified:   arch/Externals.cfg
 	modified:   dyn_em/module_first_rk_step_part1.F
 	modified:   phys/module_sf_sfclayrev.F
 	modified:   phys/module_surface_driver.F
@Songyou184 Songyou184 requested review from a team as code owners February 19, 2026 22:01
@dudhia
Copy link
Collaborator

dudhia commented Feb 19, 2026

Note for @islas and @weiwangncar
Songyou is splitting his PR into three parts. This currently uses manage_externals which probably needs changing.

@weiwangncar
Copy link
Collaborator

@Songyou184 @dudhia See my email on how to use submodules.

 	modified:   arch/Externals.cfg
@Songyou184 Songyou184 requested a review from a team as a code owner February 20, 2026 16:48
@weiwangncar
Copy link
Collaborator

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants