GWDO2026 : # 2 of GWDO and SHINHONG PBL PR#2285
Open
Songyou184 wants to merge 3 commits intowrf-model:developfrom
Open
GWDO2026 : # 2 of GWDO and SHINHONG PBL PR#2285Songyou184 wants to merge 3 commits intowrf-model:developfrom
Songyou184 wants to merge 3 commits intowrf-model:developfrom
Conversation
modified: Registry/Registry.EM_COMMON modified: arch/Externals.cfg modified: dyn_em/module_first_rk_step_part1.F modified: phys/module_bl_gwdo.F modified: phys/module_pbl_driver.F
modified: .gitmodules modified: arch/Externals.cfg
Collaborator
|
@Songyou184 @dudhia It doesn't seem that the GWDO and ShinHong PBL code are separated. Both PRs 2285 and 2286 contain changes for both options. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first line should be a single-line "purpose" for this change
TYPE: choose one of [bug fix, enhancement, new feature, feature removed, no impact, text only]
KEYWORDS: 5 to 10 words related to commit, separated by commas
SOURCE: Either "developer's name (affiliation)" .XOR. "internal" for a WRF Dev committee member
DESCRIPTION OF CHANGES:
Problem:
Generally or specifically, what was wrong and needed to be addressed?
Solution:
What was down algorithmically and in the source code to address the problem?
LIST OF MODIFIED FILES:
m Registry/Registry.EM_COMMON
m arch/Externals.cfg
m dyn_em/module_first_rk_step_part1.F
m phys/module_bl_gwdo.F
m phys/module_pbl_driver.F
TESTS CONDUCTED:
RELEASE NOTE: Include a stand-alone message suitable for the inclusion in the minor and annual releases. A publication citation is appropriate.