ci: fix pre-existing reds — pin toolchain, drop --all-features (nightly ratchet)#38
Open
dcondrey wants to merge 3 commits into
Open
ci: fix pre-existing reds — pin toolchain, drop --all-features (nightly ratchet)#38dcondrey wants to merge 3 commits into
dcondrey wants to merge 3 commits into
Conversation
Two pre-existing CI reds, both systemic: - Test (all OS) + Clippy used --all-features, which enables the protocol crate's wasm feature -> pulls the nightly-only ratchet crate -> fails to compile on stable. Switch to --workspace (wasm is built separately for a wasm target). - fmt/clippy drifted because the toolchain was unpinned (@stable is a moving target). Pin rust-toolchain.toml to 1.94.0 so fmt/clippy are reproducible.
Auto-fixable clippy lints (to_vec, clone-on-Copy, collapsible-if), a clamp() and an #[allow(too_many_arguments)] on an 11-param FFI export, plus a workspace-wide cargo fmt to make fmt --check deterministic on the pin.
Two integration-test initializers predated the window_number field on WindowInfo and no longer compiled under cargo test --workspace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the long-standing red CI on
main(Check & Lint + Test on all OSes), root-caused to two systemic issues:--all-featurespulls nightlyratchet— the protocol crate'swasmfeature depends onratchet, which uses#![feature]and fails on stable (error[E0554]). This brokecargo test --all-features(all 3 OS Test jobs) andcargo clippy --all-features. Switched both to--workspace; wasm is built separately for a wasm target.@stable(a moving target) and norust-toolchain.toml, formatting + lints drifted. Pinned to 1.94.0 for reproducibility; appliedcargo fmt+ the resulting clippy fixes (to_vec, clone-on-Copy, clamp, an#[allow(too_many_arguments)]on an 11-param FFI export).Verified locally on 1.94.0:
cargo clippy --workspace -- -D warningsclean,cargo fmt --all --checkclean. The big diff is the one-timecargo fmtnormalization.