Fix pytest 8.4 incompatibility#29
Open
ndhansen wants to merge 4 commits into
Open
Conversation
|
I ran into the same problem! Hello @wronglink -- any chance you could look into this? |
arthurio
approved these changes
Jul 24, 2025
arthurio
left a comment
arthurio
left a comment
There was a problem hiding this comment.
LGTM, thanks for taking a crack at it 👍🏻
| @@ -1,5 +1,5 @@ | |||
| [tox] | |||
| envlist = py26,py27,py34,py35,py36,py37,flake8 | |||
| envlist = py26,py27,py34,py35,py36,py37,py313,flake8 | |||
There was a problem hiding this comment.
Let's remove the old ones and add the intermediary ones?
Suggested change
| envlist = py26,py27,py34,py35,py36,py37,py313,flake8 | |
| envlist = py34,py35,py36,py37,py38,py39,py310,py311,py312,py313,flake8 |
|
Any chance of getting this merged? |
delton-ecometrica
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When this package was written, it was targetting version pytest 2.0, which had no public cleanup interface, and it called the protected
config._cleanup. In version 2.7 the publicadd_cleanupflag was added (MR).Then, in version 8.4, the protected variable was renamed, and this package broke.
My MR fixes this bug. I reused the existing tests to make sure it works, and ran them using python 3.13 and pytest 8.4. I don't have any older python versions lying around to test it with, but given the scope of the change it's unlikely to cause regressions.
I bumped the required version of pytest to 7.0, simply because with python 3.13 I wasn't able to get it to work on older versions and I decided the subset of people using this plugin and pytest <7 would be small.
Fixes #28