Skip to content

Add Azure secret provider support#3286

Merged
nisan-abeywickrama merged 3 commits intowso2:choreofrom
nisan-abeywickrama:choreo
Oct 16, 2025
Merged

Add Azure secret provider support#3286
nisan-abeywickrama merged 3 commits intowso2:choreofrom
nisan-abeywickrama:choreo

Conversation

@nisan-abeywickrama
Copy link
Copy Markdown

@nisan-abeywickrama nisan-abeywickrama commented Oct 16, 2025

Purpose

This pull request introduces support for Azure Key Vault as a secret provider in addition to HashiCorp Vault, and refines how secret providers are configured and deployed with the Helm charts. The changes make the secret management setup more flexible and allow users to choose between Azure and Vault providers via configuration.

Approach

Secret Provider Support Enhancements:

  • Added a new template file secret-provider-azure.yaml for configuring Azure Key Vault as a secret provider, including all necessary secret mappings and parameters.
  • Updated logic in the Vault secret provider template (secret-provider-vault.yaml, formerly secret-provider-class.yaml) to conditionally render only when Vault is selected as the provider. [1] [2]

Configuration Improvements:

  • Added a .Values.wso2.apk.secretProviderClass.provider field to values.yaml to allow selection between "vault" and "azure" providers, and set the default to "vault".
  • Enabled the secret provider class by default in values.yaml to ensure secrets are provisioned automatically.
  • Extended the configuration options under the Vault section in values.yaml to include Azure-specific fields (keyVaultName, azureTenantID) for easier switching and management.

Related Issue

https://github.com/wso2-enterprise/apim-saas/issues/1093

@nisan-abeywickrama nisan-abeywickrama added the trigger-action When this includes apk actions getting trigger for pr label Oct 16, 2025
@renuka-fernando
Copy link
Copy Markdown

Let's update the chart version as well.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.26%. Comparing base (58f9cec) to head (0f7c3b9).
⚠️ Report is 235 commits behind head on choreo.

Additional details and impacted files
@@             Coverage Diff             @@
##           choreo    #3286       +/-   ##
===========================================
+ Coverage   16.82%   80.26%   +63.43%     
===========================================
  Files         231        6      -225     
  Lines       39130      527    -38603     
  Branches        0      107      +107     
===========================================
- Hits         6584      423     -6161     
+ Misses      32109      104    -32005     
+ Partials      437        0      -437     
Flag Coverage Δ
adapter ?
common-controller ?
idp-domain-service 80.26% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nisan-abeywickrama nisan-abeywickrama added trigger-action When this includes apk actions getting trigger for pr and removed trigger-action When this includes apk actions getting trigger for pr labels Oct 16, 2025
@renuka-fernando renuka-fernando added trigger-action When this includes apk actions getting trigger for pr and removed trigger-action When this includes apk actions getting trigger for pr labels Oct 16, 2025
@nisan-abeywickrama nisan-abeywickrama added trigger-action When this includes apk actions getting trigger for pr and removed trigger-action When this includes apk actions getting trigger for pr labels Oct 16, 2025
@nisan-abeywickrama nisan-abeywickrama merged commit f95c7ac into wso2:choreo Oct 16, 2025
12 of 14 checks passed
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants