Add Azure secret provider support#3286
Merged
nisan-abeywickrama merged 3 commits intowso2:choreofrom Oct 16, 2025
Merged
Conversation
5019fad to
03186e8
Compare
03186e8 to
0f7c3b9
Compare
|
Let's update the chart version as well. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## choreo #3286 +/- ##
===========================================
+ Coverage 16.82% 80.26% +63.43%
===========================================
Files 231 6 -225
Lines 39130 527 -38603
Branches 0 107 +107
===========================================
- Hits 6584 423 -6161
+ Misses 32109 104 -32005
+ Partials 437 0 -437
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
renuka-fernando
previously approved these changes
Oct 16, 2025
renuka-fernando
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces support for Azure Key Vault as a secret provider in addition to HashiCorp Vault, and refines how secret providers are configured and deployed with the Helm charts. The changes make the secret management setup more flexible and allow users to choose between Azure and Vault providers via configuration.
Approach
Secret Provider Support Enhancements:
secret-provider-azure.yamlfor configuring Azure Key Vault as a secret provider, including all necessary secret mappings and parameters.secret-provider-vault.yaml, formerlysecret-provider-class.yaml) to conditionally render only when Vault is selected as the provider. [1] [2]Configuration Improvements:
.Values.wso2.apk.secretProviderClass.providerfield tovalues.yamlto allow selection between "vault" and "azure" providers, and set the default to "vault".values.yamlto ensure secrets are provisioned automatically.values.yamlto include Azure-specific fields (keyVaultName,azureTenantID) for easier switching and management.Related Issue
https://github.com/wso2-enterprise/apim-saas/issues/1093