Skip to content

Update secret provider values based on provider#3287

Merged
nisan-abeywickrama merged 4 commits intowso2:choreofrom
nisan-abeywickrama:choreo
Oct 16, 2025
Merged

Update secret provider values based on provider#3287
nisan-abeywickrama merged 4 commits intowso2:choreofrom
nisan-abeywickrama:choreo

Conversation

@nisan-abeywickrama
Copy link
Copy Markdown

@nisan-abeywickrama nisan-abeywickrama commented Oct 16, 2025

Purpose

This pull request updates the way secret keys and paths are referenced in the Helm chart templates for both Azure and Vault secret providers. The main change is to use provider-specific nested fields (azure or vault) for secret names, keys, paths, and versions, improving clarity and maintainability in secret management.

Approach

Secret provider template updates:

Azure Secret Provider (secret-provider-azure.yaml)

  • All secret references now use .azure.secretName and .azure.version fields instead of the previous .key and .path for each secret object, ensuring consistency with Azure's secret structure.

Related Issue

https://github.com/wso2-enterprise/apim-saas/issues/1440

@nisan-abeywickrama nisan-abeywickrama added the trigger-action When this includes apk actions getting trigger for pr label Oct 16, 2025
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 23.71%. Comparing base (58f9cec) to head (b0acaac).
⚠️ Report is 239 commits behind head on choreo.

Additional details and impacted files
@@            Coverage Diff             @@
##           choreo    #3287      +/-   ##
==========================================
+ Coverage   16.82%   23.71%   +6.88%     
==========================================
  Files         231       44     -187     
  Lines       39130     5044   -34086     
  Branches        0     1572    +1572     
==========================================
- Hits         6584     1196    -5388     
+ Misses      32109     3848   -28261     
+ Partials      437        0     -437     
Flag Coverage Δ
adapter ?
common-controller ?
config-deployer-service 23.71% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nisan-abeywickrama nisan-abeywickrama added trigger-action When this includes apk actions getting trigger for pr and removed trigger-action When this includes apk actions getting trigger for pr labels Oct 16, 2025
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Oct 16, 2025
@nisan-abeywickrama nisan-abeywickrama added the trigger-action When this includes apk actions getting trigger for pr label Oct 16, 2025
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Oct 16, 2025
@nisan-abeywickrama nisan-abeywickrama merged commit 5ec0c8f into wso2:choreo Oct 16, 2025
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants