Update secret provider values based on provider#3287
Merged
nisan-abeywickrama merged 4 commits intowso2:choreofrom Oct 16, 2025
Merged
Update secret provider values based on provider#3287nisan-abeywickrama merged 4 commits intowso2:choreofrom
nisan-abeywickrama merged 4 commits intowso2:choreofrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## choreo #3287 +/- ##
==========================================
+ Coverage 16.82% 23.71% +6.88%
==========================================
Files 231 44 -187
Lines 39130 5044 -34086
Branches 0 1572 +1572
==========================================
- Hits 6584 1196 -5388
+ Misses 32109 3848 -28261
+ Partials 437 0 -437
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e732129 to
e461b2f
Compare
renuka-fernando
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the way secret keys and paths are referenced in the Helm chart templates for both Azure and Vault secret providers. The main change is to use provider-specific nested fields (
azureorvault) for secret names, keys, paths, and versions, improving clarity and maintainability in secret management.Approach
Secret provider template updates:
Azure Secret Provider (
secret-provider-azure.yaml).azure.secretNameand.azure.versionfields instead of the previous.keyand.pathfor each secret object, ensuring consistency with Azure's secret structure.Related Issue
https://github.com/wso2-enterprise/apim-saas/issues/1440