Add nodePublishSecretRef to secret provider class volumes#3290
Merged
nisan-abeywickrama merged 2 commits intowso2:choreofrom Oct 22, 2025
Merged
Add nodePublishSecretRef to secret provider class volumes#3290nisan-abeywickrama merged 2 commits intowso2:choreofrom
nisan-abeywickrama merged 2 commits intowso2:choreofrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## choreo #3290 +/- ##
==========================================
- Coverage 16.82% 0.60% -16.23%
==========================================
Files 231 42 -189
Lines 39130 4809 -34321
==========================================
- Hits 6584 29 -6555
+ Misses 32109 4780 -27329
+ Partials 437 0 -437
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CrowleyRajapakse
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request enhances the configuration of secret provider classes in several Helm chart deployment templates by introducing support for the
nodePublishSecretRefparameter.Approach
Helm chart deployment improvements:
nodePublishSecretRefparameter in the secret volume configuration for the following deployments:adapter-deployment.yaml,common-controller-deployment.yaml,gateway-runtime-deployment.yaml, andratelimiter-deployment.yaml. This enables referencing a specific Kubernetes secret when mounting secrets with the CSI driver.Configuration enhancements:
nodePublishSecretReffield underwso2.apk.secretProviderClassinvalues.yaml, allowing users to configure this value via Helm values.