Skip to content

Add nodePublishSecretRef to secret provider class volumes#3290

Merged
nisan-abeywickrama merged 2 commits intowso2:choreofrom
nisan-abeywickrama:choreo
Oct 22, 2025
Merged

Add nodePublishSecretRef to secret provider class volumes#3290
nisan-abeywickrama merged 2 commits intowso2:choreofrom
nisan-abeywickrama:choreo

Conversation

@nisan-abeywickrama
Copy link
Copy Markdown

Purpose

This pull request enhances the configuration of secret provider classes in several Helm chart deployment templates by introducing support for the nodePublishSecretRef parameter.

Approach

Helm chart deployment improvements:

  • Added support for the optional nodePublishSecretRef parameter in the secret volume configuration for the following deployments: adapter-deployment.yaml, common-controller-deployment.yaml, gateway-runtime-deployment.yaml, and ratelimiter-deployment.yaml. This enables referencing a specific Kubernetes secret when mounting secrets with the CSI driver.

Configuration enhancements:

  • Introduced the nodePublishSecretRef field under wso2.apk.secretProviderClass in values.yaml, allowing users to configure this value via Helm values.

@nisan-abeywickrama nisan-abeywickrama added the trigger-action When this includes apk actions getting trigger for pr label Oct 21, 2025
@nisan-abeywickrama nisan-abeywickrama requested review from renuka-fernando and removed request for Krishanx92 October 21, 2025 18:11
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.60%. Comparing base (58f9cec) to head (8a5f7d0).
⚠️ Report is 252 commits behind head on choreo.

Additional details and impacted files
@@            Coverage Diff             @@
##           choreo   #3290       +/-   ##
==========================================
- Coverage   16.82%   0.60%   -16.23%     
==========================================
  Files         231      42      -189     
  Lines       39130    4809    -34321     
==========================================
- Hits         6584      29     -6555     
+ Misses      32109    4780    -27329     
+ Partials      437       0      -437     
Flag Coverage Δ
adapter ?
common-controller 0.60% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nisan-abeywickrama nisan-abeywickrama added trigger-action When this includes apk actions getting trigger for pr and removed trigger-action When this includes apk actions getting trigger for pr labels Oct 21, 2025
@nisan-abeywickrama nisan-abeywickrama merged commit de577aa into wso2:choreo Oct 22, 2025
22 of 23 checks passed
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants