Skip to content

Add GCP secret provider support#3308

Merged
Thushani-Jayasekera merged 1 commit intowso2:choreofrom
nisan-abeywickrama:choreo
Nov 16, 2025
Merged

Add GCP secret provider support#3308
Thushani-Jayasekera merged 1 commit intowso2:choreofrom
nisan-abeywickrama:choreo

Conversation

@nisan-abeywickrama
Copy link
Copy Markdown

Purpose

This pull request adds support for Google Cloud Platform (GCP) as a secret provider in the Helm charts, alongside the existing AWS support. It introduces a new SecretProviderClass template for GCP and updates deployment templates to handle both AWS and GCP providers. The chart version is also incremented to reflect these changes.

Purpose

Secret provider enhancements:

  • Added a new secret-provider-gcp.yaml template to configure GCP as a SecretProviderClass, enabling Kubernetes deployments to fetch secrets from GCP Secret Manager.
  • Updated deployment templates (adapter-deployment.yaml, common-controller-deployment.yaml, gateway-runtime-deployment.yaml, ratelimiter-deployment.yaml) to support both AWS and GCP as secret providers by modifying conditional logic to check for either provider.

Chart versioning:

  • Bumped the Helm chart version from 1.3.0-25 to 1.3.0-26 in Chart.yaml to reflect the new features.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Nov 16, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nisan-abeywickrama nisan-abeywickrama added the trigger-action When this includes apk actions getting trigger for pr label Nov 16, 2025
@Thushani-Jayasekera Thushani-Jayasekera merged commit e0ab6e8 into wso2:choreo Nov 16, 2025
22 of 23 checks passed
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Nov 16, 2025
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.60%. Comparing base (9d952a7) to head (a42df7e).
⚠️ Report is 10 commits behind head on choreo.

Additional details and impacted files
@@          Coverage Diff           @@
##           choreo   #3308   +/-   ##
======================================
  Coverage    0.60%   0.60%           
======================================
  Files          42      42           
  Lines        4809    4809           
======================================
  Hits           29      29           
  Misses       4780    4780           
Flag Coverage Δ
common-controller 0.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants