test(security): catalog invariants + fill negative-test gaps (M1.2)#3
Merged
Conversation
Introduces packages/{core,tools}/test/security/ as the single index
for the project's load-bearing safety invariants:
README.md -- catalogue of every invariant
and the test that pins it
bash-parser-rejections.test.ts -- per-syntax rejections: ; | & > <
$() backticks, null bytes,
parent traversal in path args,
absolute paths, rm/mv/git commit
path-traversal.test.ts -- Read/Glob/Edit/Write/Grep reject
.. escapes outside cwd
hook-preuse-blocks-tool.test.ts -- PreToolUse exit-2 stops Write
before the file is touched
scheduler-write-serialization.test.ts-- partitionToolCalls never groups
two writes in a parallel batch;
executeToolBatch keeps them
strictly sequential
test-file-hygiene.test.ts -- meta-check: no test embeds a
Windows drive-letter,
/home/<user>/, or /Users/<user>/
literal (the M1.1 lesson)
Also fixes a Windows-only TaskStore race surfaced under the new test
load: concurrent `patch` calls on the same task could interleave their
load+save sequences and roll back a "killed" patch with a stale
"running" snapshot from an appendOutput patch. Two defenses:
1. Per-task lock around `patch` so load+save is atomic per task id.
2. `renameWithRetry` for the atomic write tempfile rename, since
Windows transiently returns EBUSY/EPERM/EACCES on the destination
when AV, indexer, or another handle has it open.
Verified 10/10 green locally before pushing.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces packages/{core,tools}/test/security/ as the single index for the project's load-bearing safety invariants:
README.md -- catalogue of every invariant
and the test that pins it
bash-parser-rejections.test.ts -- per-syntax rejections: ; | & > <
$() backticks, null bytes,
parent traversal in path args,
absolute paths, rm/mv/git commit
path-traversal.test.ts -- Read/Glob/Edit/Write/Grep reject
.. escapes outside cwd
hook-preuse-blocks-tool.test.ts -- PreToolUse exit-2 stops Write
before the file is touched
scheduler-write-serialization.test.ts-- partitionToolCalls never groups
two writes in a parallel batch;
executeToolBatch keeps them
strictly sequential
test-file-hygiene.test.ts -- meta-check: no test embeds a
Windows drive-letter,
/home//, or /Users//
literal (the M1.1 lesson)
Also fixes a Windows-only TaskStore race surfaced under the new test load: concurrent
patchcalls on the same task could interleave their load+save sequences and roll back a "killed" patch with a stale "running" snapshot from an appendOutput patch. Two defenses:patchso load+save is atomic per task id.renameWithRetryfor the atomic write tempfile rename, since Windows transiently returns EBUSY/EPERM/EACCES on the destination when AV, indexer, or another handle has it open.Verified 10/10 green locally before pushing.