Skip to content

Refresh CI checks before reviewer and coder handoffs#557

Merged
wwind123 merged 1 commit into
mainfrom
codex/issue-555-refresh-ci-checks
Jul 13, 2026
Merged

Refresh CI checks before reviewer and coder handoffs#557
wwind123 merged 1 commit into
mainfrom
codex/issue-555-refresh-ci-checks

Conversation

@wwind123

Copy link
Copy Markdown
Owner

Fixes #555

Summary

  • Refresh PR checks immediately before each non-resumed reviewer prompt and again before final disposition.
  • Keep pending/unavailable/passing/no-checks non-blocking while routing completed failures to coder feedback.
  • Include normalized failing-check status and details URLs in prompts and public output.
  • Add deterministic pending-to-failing and pending-to-passing cadence regressions.

Tests

  • python3 -m pytest tests/test_orchestrator_pr.py tests/test_prompts.py
  • python3 -m pytest

@wwind123

Copy link
Copy Markdown
Owner Author

Implemented and opened PR #557 for issue #555.

  • Refreshes GitHub PR checks before each reviewer handoff and before final disposition.
  • Routes completed failures to coder feedback with check status and details URLs.
  • Adds pending-to-failing and pending-to-passing regression coverage.

Tests: python3 -m pytest tests/test_orchestrator_pr.py tests/test_prompts.py and python3 -m pytest — passed (1,523 tests).

-- OpenAI Codex: gpt-5.6-luna

@wwind123

Copy link
Copy Markdown
Owner Author

Review verdict: Approved

Refreshes GitHub PR checks per-reviewer immediately before each review prompt and again right before the stop/coder/auto-merge decision, using the per-reviewer snapshot consistently for the pending-CI-only-restated-review check. Also surfaces the failing check's details URL in both the coder-facing and reviewer-facing check formatting. This matches the issue's requirements and is covered by two new regression tests (pending→failing between reviewers routed to coder; pending→passing staying non-blocking), plus a URL-rendering unit test. Verified no stale pr_checks references remain and the refactor doesn't introduce any unbound-variable risk in the resumed-review skip path.

-- Anthropic Claude: claude-sonnet-5

@wwind123
wwind123 merged commit 4f0c724 into main Jul 13, 2026
1 check passed
@wwind123
wwind123 deleted the codex/issue-555-refresh-ci-checks branch July 13, 2026 07:28
@wwind123

Copy link
Copy Markdown
Owner Author

Review verdict: Approved

Refresh logic skips surfacing failing CI checks in coder prompts when reviewers also block

-- Google Antigravity: Gemini 3.1 Pro (High)

@wwind123

Copy link
Copy Markdown
Owner Author

GitHub PR checks are still pending for PR #557.

Reviewer approvals do not make this PR merge-ready until GitHub PR checks are green, or the PR explicitly states that only a local subset passed.

  • Pending checks: test (in_progress)
  • Required status checks are not configured on the PR base branch.

-- coding-review-agent-loop

@wwind123

Copy link
Copy Markdown
Owner Author

Reviewers approved PR #557, but GitHub checks are still pending.

This run cannot confirm the PR is merge-ready yet. Wait for CI. If checks pass, you can merge manually; no rerun is required. Rerun only if you want agent-loop to re-check or automate the final step. If checks fail, inspect/fix the failure or rerun so the loop can drive a fix.

  • Pending checks: test (in_progress)
  • Required status checks are not configured on the PR base branch.

-- coding-review-agent-loop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refresh CI checks before reviewer and coder handoffs

1 participant