Open
Conversation
Owner
|
thanks will check this |
Owner
|
|
Author
Will have a look |
|
Bump |
thearst3rd
reviewed
Jun 22, 2021
| float eps = 0.1f; | ||
|
|
||
| // check if mouse is moving | ||
| if ((-eps < px && px < eps) || (-eps < py && py < eps)) { |
There was a problem hiding this comment.
I think this line is causing the problem @xCuri0 is referring to. ((-eps < px && px < eps) || (-eps < py && py < eps)) will return true if either px or py is almost zero. This will cause it to detect a not-moving mouse. Rather, the line should be:
if (px < -eps || px > eps || py < -eps || py > eps)
That will only trigger the condition if the mouse is actively moving rather than the other way around.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

There were two key errors in the original mod that made it not work.
I've fixed both these issues and can confirm the mod now works.