bugfix: synchronize MTP compute stream after draft/validate forward.#1838
bugfix: synchronize MTP compute stream after draft/validate forward.#1838yingxudeng wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request modifies run_llm_no_sync_impl in mtp_worker_impl.cpp to synchronize the compute stream and assert on its return value. The review feedback points out that performing synchronization inside a function explicitly designed for asynchronous execution (no_sync) violates its contract and can hinder performance pipelining. Additionally, the return value of synchronize() should be declared as a plain int rather than int32_t to match the API signature, as per the repository style guide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
bugfix: |
Description
Related Issues
Change Type
Pull Request Checklist
Thank you for contributing to xLLM. Before requesting review, please make sure the following items are complete.
PR Title and Commit Messages
<type>: <subject>.Pre-commit Checks
pre-commitby runningpip install pre-commitor an equivalent command.pre-commit install.pre-commit run --all-filesand fixed any reported issues.Self Review
.agents/skills/code-review/references/custom-code-style.md, especially code written or assisted by AI.mainbranch.Build and Test Coverage
python setup.py build testhas passed on a CUDA machine.python setup.py build testhas passed on an NPU machine.python setup.py build testhas passed on an MLU machine.Reviewer Notes