Skip to content

refactor: prefer std::make_unique and std::make_shared to direct use of new.#1930

Open
Dragonliu2018 wants to merge 1 commit into
xLLM-AI:mainfrom
Dragonliu2018:lzl/refactor/prefer_make_unique_make_shared
Open

refactor: prefer std::make_unique and std::make_shared to direct use of new.#1930
Dragonliu2018 wants to merge 1 commit into
xLLM-AI:mainfrom
Dragonliu2018:lzl/refactor/prefer_make_unique_make_shared

Conversation

@Dragonliu2018

@Dragonliu2018 Dragonliu2018 commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

Description

Replace new with std::make_unique and std::make_shared following "Effective Modern C++" Item 21 guidelines.

Item 21: Prefer std::make_unique and std::make_shared to direct use of new.

Related Issues

Change Type

  • Bug fix
  • New feature
  • Performance improvement
  • Refactor
  • Documentation
  • Test
  • Build or CI

Pull Request Checklist

Thank you for contributing to xLLM. Before requesting review, please make sure the following items are complete.

PR Title and Commit Messages

  • The PR title and each commit message follow the xLLM commit format: <type>: <subject>.

Allowed types: feat, bugfix, docs, test, refactor, chore, style, revert, perf, model, build, release.
The subject should use clear English, start with a verb, include at least 4 words, and end with ..

Pre-commit Checks

  • I have installed pre-commit by running pip install pre-commit or an equivalent command.
  • I have installed the hooks with pre-commit install.
  • I have run pre-commit run --all-files and fixed any reported issues.

If you are unsure how to set up pre-commit, see the pre-commit documentation.

Self Review

  • I have self-reviewed the code according to .agents/skills/code-review/references/custom-code-style.md, especially code written or assisted by AI.
  • I have rebased this PR onto the latest main branch.

Build and Test Coverage

  • Tests have been added or updated as needed.
  • CUDA: python setup.py build test has passed on a CUDA machine.
  • NPU: python setup.py build test has passed on an NPU machine.
  • MLU: python setup.py build test has passed on an MLU machine.

Reviewer Notes

@Dragonliu2018 Dragonliu2018 force-pushed the lzl/refactor/prefer_make_unique_make_shared branch from 2cb8720 to 3c4b6c8 Compare July 12, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant