Fix stale perlin test that pins dropped-coords behavior (main is red)#3488
Closed
brendancol wants to merge 1 commit into
Closed
Fix stale perlin test that pins dropped-coords behavior (main is red)#3488brendancol wants to merge 1 commit into
brendancol wants to merge 1 commit into
Conversation
4 tasks
Contributor
Author
|
Superseded by #3489, which already fixed the same stale perlin coords test on main (parallel duplicate). Closing as redundant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis currently red on therun (..., 3.14)checks. The matrix runs fail-fast, so when the ubuntu 3.14 job fails the macOS/Windows/3.14t jobs report as canceled, but there is only one real failure:This is a merge race between two perlin PRs:
test_perlin_drops_input_coords, pinning the old behavior whereperlin()dropped input coordinates. Its comment says to "Flip this to assert the coords ARE preserved once that is fixed."perlin()to preserve the caller's x/y coordinates, but did not update the pinning test.They merged in an order that left the test asserting behavior the code no longer has.
This flips the test to match the shipped behavior: it now asserts the coordinates are preserved and equal to the input, and is renamed
test_perlin_preserves_input_coords. No source changes;perlin()already does the right thing.Test plan:
pytest xrspatial/tests/test_perlin.py— 31 passed