Skip to content

Fix stale perlin test that pins dropped-coords behavior (main is red)#3488

Closed
brendancol wants to merge 1 commit into
mainfrom
fix-perlin-drops-coords-test
Closed

Fix stale perlin test that pins dropped-coords behavior (main is red)#3488
brendancol wants to merge 1 commit into
mainfrom
fix-perlin-drops-coords-test

Conversation

@brendancol

Copy link
Copy Markdown
Contributor

main is currently red on the run (..., 3.14) checks. The matrix runs fail-fast, so when the ubuntu 3.14 job fails the macOS/Windows/3.14t jobs report as canceled, but there is only one real failure:

FAILED xrspatial/tests/test_perlin.py::test_perlin_drops_input_coords
AssertionError: assert 'lat' not in Coordinates: ...

This is a merge race between two perlin PRs:

They merged in an order that left the test asserting behavior the code no longer has.

This flips the test to match the shipped behavior: it now asserts the coordinates are preserved and equal to the input, and is renamed test_perlin_preserves_input_coords. No source changes; perlin() already does the right thing.

Test plan:

  • pytest xrspatial/tests/test_perlin.py — 31 passed

@brendancol

Copy link
Copy Markdown
Contributor Author

Superseded by #3489, which already fixed the same stale perlin coords test on main (parallel duplicate). Closing as redundant.

@brendancol brendancol closed this Jun 25, 2026
@brendancol brendancol deleted the fix-perlin-drops-coords-test branch June 25, 2026 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant