Style: fix E305 and isort import ordering in flood.py#3504
Merged
brendancol merged 1 commit intoJun 26, 2026
Merged
Conversation
Cat 1 (flake8 E305): add the missing second blank line between _validate_mannings_n_dataarray and the NLCD_MANNINGS_N module-level assignment. Cat 4 (isort): collapse the from xrspatial.utils import block to the configured line_length=100 form, matching the style other modules were brought to in earlier style sweeps. No behavioural change. flake8 + isort clean; 88 flood tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Style sweep cleanup for
xrspatial/flood.py. Two findings, both reported by the project's configured tooling (setup.cfg: flake8max-line-length=100, isortline_length=100).Categories addressed:
_validate_mannings_n_dataarrayand theNLCD_MANNINGS_Nmodule-level assignment.from xrspatial.utils import (...)block to the configuredline_length=100form, matching the style other modules were brought to in earlier style sweeps.No behavioural change. Both fixes are pure formatting.
Test plan:
flake8 xrspatial/flood.pycleanisort --check-only --diff xrspatial/flood.pycleanpytest xrspatial/tests/test_flood.py(88 passed)