Style: join backslash-continued import in geotiff test (isort)#3517
Merged
Conversation
The deferred reader re-export import in xrspatial/geotiff/tests/unit/test_exception_exports_3265.py used a backslash continuation but joins to 83 chars, under the configured line_length=100, so isort wants it on one line. Formatting only, no behaviour change. flake8 and isort are clean across the geotiff subpackage after this change. Also records the geotiff row in the style-sweep state CSV.
Contributor
Author
|
review-pr: no actionable findings. Formatting-only change. One import in test_exception_exports_3265.py was reflowed from a backslash continuation onto a single 83-char line (under the line_length=100 limit), plus the style-sweep state CSV row. The domain checks (algorithm accuracy, NaN handling, dask/cupy parity, performance) do not apply to a test import reflow. Verified: flake8 and isort --check-only both clean on xrspatial/geotiff/; test_exception_exports_3265.py passes 6/6. Good to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the one isort finding in the geotiff subpackage under the configured
line_length=100 (setup.cfg).
Category addressed: Cat 4 (isort import formatting).
xrspatial/geotiff/tests/unit/test_exception_exports_3265.py had a deferred
import written with a backslash continuation:
Joined it onto one line (83 chars, under the 100-column limit) so
isort --check-onlypasses:Formatting only, no behaviour change. flake8 over the whole geotiff subpackage
(source and tests) was already clean; isort now passes too. This was the only
finding from the style sweep of the subpackage.