test(templates): cover single-pixel/strip grids and resolution-tuple validation#3540
Merged
brendancol merged 2 commits intoJun 26, 2026
Conversation
…validation Adds test-only coverage for two reachable from_template paths the test-coverage sweep found untested: - the max(1, ...) width/height floor (single-pixel and Nx1/1xN strip) - the _normalize_resolution wrong-length tuple ValueError No source change; behavior was already correct. Also records the templates row in the test-coverage sweep state CSV.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test-only coverage for two untested paths in
from_template, found by the test-coverage deep-sweep.test_single_pixel_grid: a resolution coarser than the study area clamps to a 1x1 grid viamax(1, ...); asserts shape, exactres, and all-NaN fill.test_strip_grid: a huge resolution on one axis clamps that axis to 1, giving an Nx1/1xN strip.test_resolution_tuple_wrong_length_raises: a tuple of length != 2 raisesValueError.No source change. The behavior was already correct; these just close the coverage gaps. Ran locally on a CUDA host: 66 passed, 0 skipped.