docs(templates): fix stale UTM zone in from_template FRA example#3544
Merged
Conversation
The from_template docstring example for preserve="shape" showed EPSG:32631 (UTM 31N) for France, but the function returns EPSG:32630 (UTM 30N). The GADM FRA bounding box includes overseas territories, so the centroid falls at longitude -2.98 in UTM zone 30N. The code is correct per the documented centroid-UTM contract; only the example value and inline comment were stale. Doc-only change. All 63 templates tests pass. Closes #3541
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
from_templatedocstring example forpreserve="shape"showed EPSG:32631 (UTM 31N) for France, but the function returns EPSG:32630 (UTM 30N).The GADM FRA bounding box spans longitude -61.79 to 55.84 because it includes overseas territories (French Guiana, Reunion, and others), so the centroid falls at longitude -2.98 in UTM zone 30N. The
preserve="shape"path picks the centroid's UTM zone, which is the documented contract, so 32630 is correct. The example value and inline comment were stale.Documentation-only change: corrected the expected value to 32630 and the inline comment to UTM 30N. No behavior change. All 63
test_templates.pytests pass.Found by the documentation sweep on the templates module.
Closes #3541