fix: return all-NaN pycnophylactic output for empty valid masks#3551
Open
gaoflow wants to merge 1 commit into
Open
fix: return all-NaN pycnophylactic output for empty valid masks#3551gaoflow wants to merge 1 commit into
gaoflow wants to merge 1 commit into
Conversation
|
Hi @gaoflow, thanks for the PR! Would you mind filing a quick New contributor introduction issue when you get a chance? It helps us point you at issues that fit what you'd like to work on. Most fields are optional. Reviewing your PR doesn't depend on it, just a friendly nudge. |
Contributor
|
hey @gaoflow... thanks for the PR and interest in xarray-spatial. I love to learn more about you, the stack you are using and your background in computers and geography. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3406.
Tests
uv run --with '.[tests]' pytest xrspatial/tests/test_dasymetric.py::TestPycnophylacticEmptyValid -q\n-uv run --with '.[tests]' pytest xrspatial/tests/test_dasymetric.py::TestPycnophylactic xrspatial/tests/test_dasymetric.py::TestPycnophylacticEmptyValid -q