Skip to content

fix: return all-NaN pycnophylactic output for empty valid masks#3551

Open
gaoflow wants to merge 1 commit into
xarray-contrib:mainfrom
gaoflow:fix-3406-pycnophylactic-empty-valid
Open

fix: return all-NaN pycnophylactic output for empty valid masks#3551
gaoflow wants to merge 1 commit into
xarray-contrib:mainfrom
gaoflow:fix-3406-pycnophylactic-empty-valid

Conversation

@gaoflow

@gaoflow gaoflow commented Jun 27, 2026

Copy link
Copy Markdown

Summary

Fixes #3406.

Tests

  • uv run --with '.[tests]' pytest xrspatial/tests/test_dasymetric.py::TestPycnophylacticEmptyValid -q\n- uv run --with '.[tests]' pytest xrspatial/tests/test_dasymetric.py::TestPycnophylactic xrspatial/tests/test_dasymetric.py::TestPycnophylacticEmptyValid -q

@github-actions

Copy link
Copy Markdown

Hi @gaoflow, thanks for the PR!

Would you mind filing a quick New contributor introduction issue when you get a chance? It helps us point you at issues that fit what you'd like to work on. Most fields are optional.

Reviewing your PR doesn't depend on it, just a friendly nudge.

@github-actions github-actions Bot added the performance PR touches performance-sensitive code label Jun 27, 2026
@brendancol brendancol added waiting on contributor and removed performance PR touches performance-sensitive code labels Jun 27, 2026
@brendancol

Copy link
Copy Markdown
Contributor

hey @gaoflow... thanks for the PR and interest in xarray-spatial. I love to learn more about you, the stack you are using and your background in computers and geography.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pycnophylactic raises opaque ValueError on all-NaN zones or no matching zone id

2 participants