Skip to content

Sort templates.py imports to match the project isort config#3578

Merged
brendancol merged 1 commit into
xarray-contrib:mainfrom
brendancol:deep-sweep-style-templates-2026-06-30-01
Jul 1, 2026
Merged

Sort templates.py imports to match the project isort config#3578
brendancol merged 1 commit into
xarray-contrib:mainfrom
brendancol:deep-sweep-style-templates-2026-06-30-01

Conversation

@brendancol

Copy link
Copy Markdown
Contributor

Closes #3577.

Runs isort over xrspatial/templates.py so the _template_data import block matches the project's line_length = 100 config. flake8 was already clean; this is the only style finding in the module.

  • Collapses the _UPS_NORTH_EPSG / _UPS_SOUTH_EPSG import onto one line (98 chars, within the limit)
  • Imports only, no runtime behavior change

Test plan:

  • isort --check-only --diff xrspatial/templates.py passes
  • flake8 xrspatial/templates.py stays clean

@brendancol brendancol left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the diff. It collapses one wrapped import in xrspatial/templates.py onto a single line so the _template_data block passes isort under the project's line_length = 100 config.

  • All names in the block stay imported; _UPS_NORTH_EPSG and _UPS_SOUTH_EPSG are both still used (lines 175-183), so nothing was dropped.
  • Resulting line is 98 characters, within the 100-column limit. flake8 stays clean.
  • Pure formatting, no runtime behavior change. Backend dispatch is unaffected.

No blockers, suggestions, or nits.

@brendancol brendancol merged commit fce62d8 into xarray-contrib:main Jul 1, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

templates.py imports fail the project's isort check

1 participant