Sort templates.py imports to match the project isort config#3578
Merged
brendancol merged 1 commit intoJul 1, 2026
Merged
Conversation
brendancol
commented
Jun 30, 2026
brendancol
left a comment
Contributor
Author
There was a problem hiding this comment.
Reviewed the diff. It collapses one wrapped import in xrspatial/templates.py onto a single line so the _template_data block passes isort under the project's line_length = 100 config.
- All names in the block stay imported;
_UPS_NORTH_EPSGand_UPS_SOUTH_EPSGare both still used (lines 175-183), so nothing was dropped. - Resulting line is 98 characters, within the 100-column limit. flake8 stays clean.
- Pure formatting, no runtime behavior change. Backend dispatch is unaffected.
No blockers, suggestions, or nits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3577.
Runs isort over
xrspatial/templates.pyso the_template_dataimport block matches the project'sline_length = 100config. flake8 was already clean; this is the only style finding in the module._UPS_NORTH_EPSG/_UPS_SOUTH_EPSGimport onto one line (98 chars, within the limit)Test plan:
isort --check-only --diff xrspatial/templates.pypassesflake8 xrspatial/templates.pystays clean