Fix isort drift in two geotiff files#3589
Merged
Merged
Conversation
brendancol
commented
Jul 2, 2026
brendancol
left a comment
Contributor
Author
There was a problem hiding this comment.
PR Review: Fix isort drift in two geotiff files
Formatting-only diff: a blank line after two inline imports and one parenthesized import joined to a single line (88 chars, under the 100-col limit). I verified both files parse to an AST identical to main, so there is no behavioral change by construction. flake8 and isort pass on the whole subpackage after the change, and the 25 symbology sidecar tests pass locally with CUDA.
The state-CSV change touches only the geotiff row.
Blockers
None.
Suggestions
None.
Nits
None.
What looks good
- The fix is the raw isort output for the two files, nothing hand-edited on top.
- Issue #3588 has the reproduction and traces the drift to the #3537 symbology work.
Most of the standard checklist (backend parity, NaN handling, dask depth, benchmarks, docs) does not apply to a whitespace change, so those sections were skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3588
xrspatial/geotiff/_writers/eager.pyandxrspatial/geotiff/tests/write/test_symbology_sidecar_3537.py. Both hunks came in with the to_geotiff: write best-practice symbology sidecars for continuous rasters (QGIS color ramp) #3537 symbology work.No behavioral change, so backend coverage is unaffected (numpy / cupy / dask+numpy / dask+cupy all untouched).
Test plan:
flake8 xrspatial/geotiff/cleanisort --check-only xrspatial/geotiff/cleanpytest xrspatial/geotiff/tests/write/test_symbology_sidecar_3537.pypasses (25 tests, CUDA available locally)